Chromium Code Reviews

Issue 2961293002: Properly export the symbols of video frame-buffer classes for link-time (Closed)

Created:
3 years, 5 months ago by VladimirTechMan
Modified:
3 years, 5 months ago
Reviewers:
magjed_webrtc, kjellander_webrtc, VladimirTechMan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Properly export the symbols of video frame-buffer classes for link-time Linking external ObjC / Swift apps fails when the app code is using any of the new frame-buffer classes RTCI420Buffer, RTCMutableI420Buffer, or RTCCVPixelBuffer. To fix, we need to add the appropriate attribute to the classes (e.g. using the RTC_EXPORT macro). BUG=None Review-Url: https://codereview.webrtc.org/2961293002 Cr-Commit-Position: refs/heads/master@{#18840} Committed: https://chromium.googlesource.com/external/webrtc/+/26afe214add12dbc3aa6e7c0265539eff8dc5d20

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -0 lines)
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h View 2 chunks +3 lines, -0 lines 0 comments

Messages

Total messages: 8 (4 generated)
VladimirTechMan
3 years, 5 months ago (2017-06-29 15:10:42 UTC) #2
magjed_webrtc
lgtm
3 years, 5 months ago (2017-06-29 15:22:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2961293002/1
3 years, 5 months ago (2017-06-29 15:53:00 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 16:11:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/26afe214add12dbc3aa6e7c02...

Powered by Google App Engine