Workaround for hardware encoders crashing timing frames processing

Workaround for hardware encoders crashing timing frames processing

BUG=webrtc:7893
Review-Url: https://codereview.webrtc.org/2961043002
Cr-Commit-Position: refs/heads/master@{#18806}
Committed: https://chromium.googlesource.com/external/webrtc/+/3635f44f3ebca0aa4e947693a7a9aa46f8c8f92a

[ilnik, 2017-06-28 10:11:37]

ilnik@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[ilnik, 2017-06-28 10:11:38]

Please review ASAP, as it's a fix for P1 crashing bug of downstream project. Fix
is trivial: Instead of crashing on RTC_CHECKs, if conditions are not met,
depending logic is excluded. No timing frames will be produced on android for
now.

[brandtr, 2017-06-28 10:33:34]

lgtm after offline discussion

https://codereview.webrtc.org/2961043002/diff/1/webrtc/modules/video_coding/g...
File webrtc/modules/video_coding/generic_encoder.cc (right):

https://codereview.webrtc.org/2961043002/diff/1/webrtc/modules/video_coding/g...
webrtc/modules/video_coding/generic_encoder.cc:252: // Some chromium remoting
unittests use generic encoder incorrectly
Maybe we should update these tests to be more correct?

[ilnik, 2017-06-28 10:36:18]

On 2017/06/28 10:33:34, brandtr wrote:
> lgtm after offline discussion
> 
>
https://codereview.webrtc.org/2961043002/diff/1/webrtc/modules/video_coding/g...
> File webrtc/modules/video_coding/generic_encoder.cc (right):
> 
>
https://codereview.webrtc.org/2961043002/diff/1/webrtc/modules/video_coding/g...
> webrtc/modules/video_coding/generic_encoder.cc:252: // Some chromium remoting
> unittests use generic encoder incorrectly
> Maybe we should update these tests to be more correct?

I did't see any easy way to do it. But I should have created a chromium bug for
it. I will do it now.

[ilnik, 2017-06-28 10:36:21]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-06-28 10:36:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-28 10:53:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498646181451500, "parent_rev":
"03fa534fccec0004b27a0db9541def9a324ef675", "commit_rev":
"3635f44f3ebca0aa4e947693a7a9aa46f8c8f92a"}

[commit-bot: I haz the power, 2017-06-28 10:53:25]

Description was changed from

==========
Workaround for hardware encoders crashing timing frames processing

BUG=webrtc:7893
==========

to

==========
Workaround for hardware encoders crashing timing frames processing

BUG=webrtc:7893

Review-Url: https://codereview.webrtc.org/2961043002
Cr-Commit-Position: refs/heads/master@{#18806}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3635f44f3ebca0aa4e947693a...
==========

[commit-bot: I haz the power, 2017-06-28 10:53:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3635f44f3ebca0aa4e947693a...