Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2959993002: Handle the PROTO_TSL when getting the protocol priority. (Closed)

Created:
3 years, 5 months ago by Zhi Huang
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Handle the PROTO_TSL when getting the protocol priority. This bug breaks the internal project. TBR=deadbeef@webrtc.org, pthacher@webrtc.org BUG=webrtc:7889 Review-Url: https://codereview.webrtc.org/2959993002 Cr-Commit-Position: refs/heads/master@{#18792} Committed: https://chromium.googlesource.com/external/webrtc/+/696f8ca2fa29b950518525b2f20b4e9c6052ddfd

Patch Set 1 #

Patch Set 2 : Update the comments. #

Total comments: 1

Patch Set 3 : Change the priority. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/p2p/client/basicportallocator.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
Zhi Huang
Please take a look.
3 years, 5 months ago (2017-06-27 20:47:40 UTC) #4
honghaiz3
lgtm https://codereview.webrtc.org/2959993002/diff/40001/webrtc/p2p/client/basicportallocator.cc File webrtc/p2p/client/basicportallocator.cc (right): https://codereview.webrtc.org/2959993002/diff/40001/webrtc/p2p/client/basicportallocator.cc#newcode54 webrtc/p2p/client/basicportallocator.cc:54: case cricket::PROTO_TLS: Maybe consider PROTO_UDP to be 3?
3 years, 5 months ago (2017-06-27 20:56:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2959993002/60001
3 years, 5 months ago (2017-06-27 22:09:32 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 22:11:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/696f8ca2fa29b950518525b2f...

Powered by Google App Engine
This is Rietveld 408576698