Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 2959183002: Start work on splitting off the usage piece of in-memory index. This revision is just from the prev…

Created:
2 years ago by Maks Orlovich
Modified:
1 year, 9 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, gavinp+disk_chromium.org, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Start work on splitting off the usage piece of in-memory index. Dependent on: https://codereview.chromium.org/2958033002/ (and will be updated if the interface there changes). BUG=729679

Patch Set 1 #

Patch Set 2 : Improve comments and naming some. #

Patch Set 3 : Move the DCHECK for partial content handling back to ConditionalizeRequest, as that has a lot more … #

Patch Set 4 : Cover both on and off cases in tests, improve some comments. #

Patch Set 5 : Rebase + merge #

Patch Set 6 : API/naming update #

Patch Set 7 : Improve some comments. #

Patch Set 8 : Rebase (after dependency committed) --- should be no-op'ish? #

Patch Set 9 : Rebase after more stuff landed #

Patch Set 10 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -129 lines) Patch
M net/base/net_error_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_cache.h View 1 2 3 4 5 6 7 4 chunks +11 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M net/http/http_cache_transaction.h View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -0 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 6 7 8 9 4 chunks +93 lines, -18 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 6 7 4 chunks +151 lines, -109 lines 0 comments Download

Messages

Total messages: 25 (25 generated)
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
2 years ago (2017-06-28 14:45:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/1
2 years ago (2017-06-28 14:46:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
2 years ago (2017-06-28 16:24:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
2 years ago (2017-06-28 16:24:31 UTC) #4
Maks Orlovich
Description was changed from ========== Start work on splitting off the usage piece of in-memory ...
2 years ago (2017-06-29 16:17:20 UTC) #5
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
1 year, 10 months ago (2017-08-23 20:12:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/80001
1 year, 10 months ago (2017-08-23 20:12:14 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
1 year, 10 months ago (2017-08-23 22:29:02 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
1 year, 10 months ago (2017-08-23 22:29:03 UTC) #9
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
1 year, 10 months ago (2017-08-28 14:11:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/100001
1 year, 10 months ago (2017-08-28 14:11:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
1 year, 10 months ago (2017-08-28 17:06:02 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
1 year, 10 months ago (2017-08-28 17:06:03 UTC) #13
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
1 year, 10 months ago (2017-08-28 17:09:10 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/120001
1 year, 10 months ago (2017-08-28 17:09:22 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
1 year, 10 months ago (2017-08-28 18:52:14 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
1 year, 10 months ago (2017-08-28 18:52:15 UTC) #17
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
1 year, 10 months ago (2017-08-30 19:44:45 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/160001
1 year, 10 months ago (2017-08-30 19:44:48 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
1 year, 10 months ago (2017-08-30 20:50:38 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/253201)
1 year, 10 months ago (2017-08-30 20:50:39 UTC) #21
Maks Orlovich
The CQ bit was checked by morlovich@chromium.org to run a CQ dry run
1 year, 9 months ago (2017-09-26 16:58:11 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959183002/180001
1 year, 9 months ago (2017-09-26 16:58:21 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
1 year, 9 months ago (2017-09-26 18:21:52 UTC) #24
commit-bot: I haz the power
1 year, 9 months ago (2017-09-26 18:21:53 UTC) #25
Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698