nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

Rationale:
1. sinks_ is not properly differentiated from rsid_sinks_.
2. Consistency with RtcpDemuxer.

BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2958283002
Cr-Commit-Position: refs/heads/master@{#18813}
Committed: https://chromium.googlesource.com/external/webrtc/+/c3e3e60f592865b671175941a972dbf6961e1b38

[eladalon, 2017-06-28 13:49:06]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, nisse@webrtc.org

[eladalon, 2017-06-28 13:49:07]

PTAL

[danilchap, 2017-06-28 14:05:39]

lgtm

https://codereview.webrtc.org/2958283002/diff/1/webrtc/call/rtp_demuxer.h
File webrtc/call/rtp_demuxer.h (right):

https://codereview.webrtc.org/2958283002/diff/1/webrtc/call/rtp_demuxer.h#new...
webrtc/call/rtp_demuxer.h:74: std::multimap<uint32_t, RtpPacketSinkInterface*>
ssrc_sinks_;
while just 'sinks' is not properly differentiated from rsid_sinks, I'm not sure
new name use right direction: These names make false impression there are two
different kind of sinks. Sinks are same, they are just mapped by different keys,
so may be call them 'sinks_by_ssrc_' and 'sinks_by_rsid_'

[eladalon, 2017-06-28 14:17:53]

On 2017/06/28 14:05:39, danilchap OOO until July17 wrote:
> lgtm
> 
> https://codereview.webrtc.org/2958283002/diff/1/webrtc/call/rtp_demuxer.h
> File webrtc/call/rtp_demuxer.h (right):
> 
>
https://codereview.webrtc.org/2958283002/diff/1/webrtc/call/rtp_demuxer.h#new...
> webrtc/call/rtp_demuxer.h:74: std::multimap<uint32_t, RtpPacketSinkInterface*>
> ssrc_sinks_;
> while just 'sinks' is not properly differentiated from rsid_sinks, I'm not
sure
> new name use right direction: These names make false impression there are two
> different kind of sinks. Sinks are same, they are just mapped by different
keys,
> so may be call them 'sinks_by_ssrc_' and 'sinks_by_rsid_'

I'm not sure which names I prefer, but I think ssrc_sinks_ is an improvement
(also more consistent with RtcpDemuxer), so I'll land this for now, and the
other improvement we might do later. I mean, soon we'll be supporting MID and
PlType, and things might look different once we reach that.

[eladalon, 2017-06-28 14:17:57]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-06-28 14:18:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-28 14:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 14:22:30]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18654)

[eladalon, 2017-06-28 14:54:59]

Description was changed from

==========
nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

Rationale:
1. sinks_ is not properly differentiated from rsid_sinks_.
2. Consistency with RtcpDemuxer.

BUG=webrtc:7135
==========

to

==========
nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

Rationale:
1. sinks_ is not properly differentiated from rsid_sinks_.
2. Consistency with RtcpDemuxer.

BUG=webrtc:7135
==========

[eladalon, 2017-06-28 14:54:59]

eladalon@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-06-28 14:57:54]

lgtm

[eladalon, 2017-06-28 14:59:55]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-06-28 15:00:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-28 15:18:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498661995038320, "parent_rev":
"9f789a4500bea5fde357227f20fa7554a2241880", "commit_rev":
"c3e3e60f592865b671175941a972dbf6961e1b38"}

[commit-bot: I haz the power, 2017-06-28 15:18:56]

Description was changed from

==========
nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

Rationale:
1. sinks_ is not properly differentiated from rsid_sinks_.
2. Consistency with RtcpDemuxer.

BUG=webrtc:7135
==========

to

==========
nit: Rename RtpDemuxer::sink_ to RtpDemuxer::ssrc_sinks_

Rationale:
1. sinks_ is not properly differentiated from rsid_sinks_.
2. Consistency with RtcpDemuxer.

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2958283002
Cr-Commit-Position: refs/heads/master@{#18813}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c3e3e60f592865b671175941a...
==========

[commit-bot: I haz the power, 2017-06-28 15:18:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c3e3e60f592865b671175941a...