Remove some occurrences of WEBRTC_TRACE in webrtc/modules/audio_device/linux/

Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24
This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears to be discarded anyway by all users.

Second patch set removes the header and makes small fixes to four of the log messages.


BUG=webrtc:5118
Review-Url: https://codereview.webrtc.org/2958273002
Cr-Commit-Position: refs/heads/master@{#18941}
Committed: https://chromium.googlesource.com/external/webrtc/+/bffe597e69f7d48816f51ff1278a544445b81501

[saza WebRTC, 2017-06-28 13:38:10]

Patchset #2 (id:20001) has been deleted

[saza WebRTC, 2017-06-28 14:12:08]

Description was changed from

==========
Run convert.py and git cl format on audio_device_pulse_linux.cc.

BUG=webrtc:5118
==========

to

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24

Second patch set removes the header and makes small fixes to four of the log
messages.

BUG=webrtc:5118
==========

[saza WebRTC, 2017-06-28 14:17:32]

Description was changed from

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24

Second patch set removes the header and makes small fixes to four of the log
messages.

BUG=webrtc:5118
==========

to

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24

Second patch set removes the header and makes small fixes to four of the log
messages.

This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears
to be discarded anyway by all users.

BUG=webrtc:5118
==========

[saza WebRTC, 2017-06-28 14:18:07]

Description was changed from

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24

Second patch set removes the header and makes small fixes to four of the log
messages.

This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears
to be discarded anyway by all users.

BUG=webrtc:5118
==========

to

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24
This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears
to be discarded anyway by all users.

Second patch set removes the header and makes small fixes to four of the log
messages.


BUG=webrtc:5118
==========

[saza WebRTC, 2017-06-28 14:19:07]

saza@webrtc.org changed reviewers:
+ henrikg@webrtc.org

[saza WebRTC, 2017-07-04 07:01:29]

saza@webrtc.org changed reviewers:
+ henrika@webrtc.org
- henrikg@webrtc.org

[saza WebRTC, 2017-07-07 13:59:18]

ptal

[henrika_webrtc, 2017-07-07 14:04:45]

LGTM with comments.

Thanks for improving!

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc (right):

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:92: LOG(LS_INFO)
<< __FUNCTION__ << " created";
Nit, bur why all these initial spaces? Could you please remove them.

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:225: LOG(LS_ERROR)
<< "  failed to terminate PulseAudio";
Same here and in the rest of the file as well...

[saza WebRTC, 2017-07-10 06:37:11]

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc (right):

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:92: LOG(LS_INFO)
<< __FUNCTION__ << " created";
On 2017/07/07 14:04:45, henrika_webrtc wrote:
> Nit, bur why all these initial spaces? Could you please remove them.

The prefixed spaces in this file indicate dependence on previous log messages.
Example:

startRec true, performing initial actions
 connected
 done

I've removed it, assuming this is no longer how we log.

For this particular log message, however, the string is basically "%s created"
and the space makes sense to me.

https://codereview.webrtc.org/2958273002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:225: LOG(LS_ERROR)
<< "  failed to terminate PulseAudio";
On 2017/07/07 14:04:45, henrika_webrtc wrote:
> Same here and in the rest of the file as well...

Done.

[saza WebRTC, 2017-07-10 07:34:12]

The CQ bit was checked by saza@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 07:34:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[henrika_webrtc, 2017-07-10 07:34:58]

Thanks for the explanation. If you are OK now I am OK as well.
Feel free to land it.

[saza WebRTC, 2017-07-10 07:48:40]

The CQ bit was unchecked by saza@webrtc.org

[saza WebRTC, 2017-07-10 07:48:41]

The CQ bit was checked by saza@webrtc.org

[saza WebRTC, 2017-07-10 07:48:41]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2958273002/#ps60001 (title:
"Remove superfluous spaces.")

[commit-bot: I haz the power, 2017-07-10 07:48:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-10 08:05:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499672921271930,
"parent_rev": "5de068082bcb95c45efd476183a3773a939291b7", "commit_rev":
"bffe597e69f7d48816f51ff1278a544445b81501"}

[commit-bot: I haz the power, 2017-07-10 08:05:50]

Description was changed from

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24
This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears
to be discarded anyway by all users.

Second patch set removes the header and makes small fixes to four of the log
messages.


BUG=webrtc:5118
==========

to

==========
Convert occurrences of deprecated WEBRTC_TRACE logging to LOG style logging in
webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc.

First patch set uses a script attached in an issue comment:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5118#c24
This discards the boilerplate prefix of WEBRTC_TRACE log strings, but it appears
to be discarded anyway by all users.

Second patch set removes the header and makes small fixes to four of the log
messages.


BUG=webrtc:5118

Review-Url: https://codereview.webrtc.org/2958273002
Cr-Commit-Position: refs/heads/master@{#18941}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bffe597e69f7d48816f51ff12...
==========

[commit-bot: I haz the power, 2017-07-10 08:05:51]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/bffe597e69f7d48816f51ff12...