Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2958123002: Support getting external HMAC auth context with libsrtp 2.1.0. (Closed)

Created:
3 years, 5 months ago by joachim
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Support getting external HMAC auth context with libsrtp 2.1.0. This is in preparation of upgrading to libsrtp 2.1.0. BUG=webrtc:7856 Review-Url: https://codereview.webrtc.org/2958123002 Cr-Commit-Position: refs/heads/master@{#18805} Committed: https://chromium.googlesource.com/external/webrtc/+/03fa534fccec0004b27a0db9541def9a324ef675

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/pc/srtpfilter.cc View 1 chunk +11 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
joachim
https://codereview.webrtc.org/2958123002/diff/1/webrtc/pc/srtpfilter.cc File webrtc/pc/srtpfilter.cc (right): https://codereview.webrtc.org/2958123002/diff/1/webrtc/pc/srtpfilter.cc#newcode568 webrtc/pc/srtpfilter.cc:568: #if defined(SRTP_MAX_MKI_LEN) The #define has been introduced in libsrtp ...
3 years, 5 months ago (2017-06-27 21:15:16 UTC) #2
Taylor Brandstetter
lgtm
3 years, 5 months ago (2017-06-28 10:18:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2958123002/1
3 years, 5 months ago (2017-06-28 10:18:47 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 10:36:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/03fa534fccec0004b27a0db95...

Powered by Google App Engine
This is Rietveld 408576698