Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 5 months ago by ilnik Modified:
3 years, 5 months ago Reviewers:
brandtr, åsapersson CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDon't disable FEC if timing frames are disabled.
Don't disable fec for packets without timing frames extension
even if they are marked as belonging to timing frames.
BUG=webrtc:7894
Review-Url: https://codereview.webrtc.org/2956263002
Cr-Commit-Position: refs/heads/master@{#18826}
Committed: https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e205f76239631e00
Patch Set 1 #Patch Set 2 : Add missing extension to test #
Created: 3 years, 5 months ago
Messages
Total messages: 21 (15 generated)
ilnik@webrtc.org changed reviewers: + brandtr@webrtc.org
Even if timing frames extension is disabled (as in e2e FEC tests), some packets were not protected by FEC. This Cl fixes that.
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/13447)
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, but please rephrase first row of commit message to be below ~60 characters. Add details in second paragraph of commit message. I'm not an OWNER in rtp_rtcp/, so maybe check with danilchap@ too.
Description was changed from ========== Don't disable fec for packets without timing frames extension, even if they are marked as timing frames BUG=webrtc:7894 ========== to ========== Don't disable FEC if timing frames are disabled. Don't disable fec for packets without timing frames extension even if they are marked as belonging to timing frames. BUG=webrtc:7894 ==========
ilnik@webrtc.org changed reviewers: + asapersson@webrtc.org
On 2017/06/29 08:51:32, brandtr wrote: > lgtm, but please rephrase first row of commit message to be below ~60 > characters. Add details in second paragraph of commit message. > > I'm not an OWNER in rtp_rtcp/, so maybe check with danilchap@ too. +Asapersson,
lgtm
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498728310989840,
"parent_rev": "8d08a92c052b985ca540a5c9928f11a6e11a019c", "commit_rev":
"efb0fc7577548c761fcbe843d7b83c5ae0f4d822"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498728310989840,
"parent_rev": "8c1ee7b73a85c74ded5a928f4f0c8eacc7d6f24d", "commit_rev":
"e4350197ecd85bf1bd47e5f3e205f76239631e00"}
Message was sent while issue was closed.
Description was changed from ========== Don't disable FEC if timing frames are disabled. Don't disable fec for packets without timing frames extension even if they are marked as belonging to timing frames. BUG=webrtc:7894 ========== to ========== Don't disable FEC if timing frames are disabled. Don't disable fec for packets without timing frames extension even if they are marked as belonging to timing frames. BUG=webrtc:7894 Review-Url: https://codereview.webrtc.org/2956263002 Cr-Commit-Position: refs/heads/master@{#18826} Committed: https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
