Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2956193002: [Android] Enable WebAPK to have multiple intent filters (Closed)

Created:
3 years, 5 months ago by pkotwicz
Modified:
3 years, 4 months ago
Reviewers:
palmer, Yaron, hartmanng
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable WebAPK to have multiple intent filters This CL: - Changes AndroidManifest.xml MoTemplate to support multiple intent filters - Moves the MoTemplate configuration to external .json files - Adds logic to rewrite URLs from deep links to the scope URL's scheme and host name. This handles the case of: 1) The WebAPK has intent filters for several TLDs (e.g. https://maps.google.ca, https://maps.google.fr, ...) 2) It is desired to change the TLD of the intent URL to '.com' so that all incoming intent URLs fall under one service worker. BUG=734131, 734136 Review-Url: https://codereview.chromium.org/2956193002 Cr-Commit-Position: refs/heads/master@{#490275} Committed: https://chromium.googlesource.com/chromium/src/+/6c7ac7c0265c50a2da530c21f040a90413a2b080

Patch Set 1 : Merge branch 'rewriting0' into rewriting #

Total comments: 13

Patch Set 2 : Merge branch 'mustache' into rewriting #

Total comments: 11

Patch Set 3 : Merge branch 'rewriting0' into rewriting #

Total comments: 1

Patch Set 4 : Merge branch 'master' into rewriting #

Patch Set 5 : Merge branch 'master' into rewriting #

Patch Set 6 : Merge branch 'master' into rewriting #

Messages

Total messages: 32 (10 generated)
pkotwicz
Yaron, can you please take a look? I change AndroidManifest.xml to be in the MoTemplate ...
3 years, 5 months ago (2017-06-28 03:19:46 UTC) #4
Yaron
https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml File chrome/android/webapk/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml#newcode27 chrome/android/webapk/shell_apk/AndroidManifest.xml:27: {{#intent_filters:intent_filters}} I'm not familiar with this syntax but have ...
3 years, 5 months ago (2017-06-28 16:55:40 UTC) #5
Yaron
https://codereview.chromium.org/2956193002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode190 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:190: // The WebAPK may have been launched as a ...
3 years, 5 months ago (2017-06-28 16:59:39 UTC) #6
Yaron
+Glenn cause this will have to be versioned properly on the server
3 years, 5 months ago (2017-06-28 17:00:11 UTC) #8
Yaron
+Glenn cause this will have to be versioned properly on the server
3 years, 5 months ago (2017-06-28 17:00:22 UTC) #9
Yaron
+palmer as I know any URL munging (although you're nicely using built-ins) raises his alarms ...
3 years, 5 months ago (2017-06-28 17:22:14 UTC) #11
hartmanng
On 2017/06/28 17:00:22, Yaron wrote: > +Glenn cause this will have to be versioned properly ...
3 years, 5 months ago (2017-06-28 18:24:33 UTC) #12
Yaron
https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml File chrome/android/webapk/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml#newcode27 chrome/android/webapk/shell_apk/AndroidManifest.xml:27: {{#intent_filters:intent_filters}} On 2017/06/28 18:24:33, hartmanng wrote: > On 2017/06/28 ...
3 years, 5 months ago (2017-06-28 18:28:47 UTC) #13
Yaron
https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/manifest_processor.py File chrome/android/webapk/shell_apk/manifest_processor.py (right): https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/manifest_processor.py#newcode10 chrome/android/webapk/shell_apk/manifest_processor.py:10: To convert Motemplate to "Mustache template" replace: Oh I ...
3 years, 5 months ago (2017-06-28 18:47:54 UTC) #14
pkotwicz
Can everyone please take another look? Now this CL uses real Mustache (and the server ...
3 years, 5 months ago (2017-06-28 20:45:06 UTC) #15
hartmanng
AndroidManifest.xml l-g-t-m https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml File chrome/android/webapk/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/2956193002/diff/20001/chrome/android/webapk/shell_apk/AndroidManifest.xml#newcode27 chrome/android/webapk/shell_apk/AndroidManifest.xml:27: {{#intent_filters:intent_filters}} On 2017/06/28 20:45:06, pkotwicz wrote: > ...
3 years, 5 months ago (2017-06-28 21:01:29 UTC) #16
palmer
https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode192 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:192: // name. This is where the rubber hits the ...
3 years, 5 months ago (2017-06-28 21:24:40 UTC) #17
pkotwicz
https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode192 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:192: // name. I think that Yaron was asking whether ...
3 years, 5 months ago (2017-06-28 22:26:21 UTC) #18
Yaron
i assume a shell apk version increase will be done as this gets closer to ...
3 years, 5 months ago (2017-06-29 02:15:07 UTC) #19
pkotwicz
Yaron, can you please take another look? I will modify shell_apk_version.gni once the third_party CL ...
3 years, 5 months ago (2017-06-29 04:46:41 UTC) #20
Yaron
https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode192 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:192: // name. On 2017/06/29 02:15:07, Yaron wrote: > On ...
3 years, 5 months ago (2017-07-10 23:39:36 UTC) #21
pkotwicz
https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode192 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:192: // name. The goal of the URL rewriting is ...
3 years, 5 months ago (2017-07-11 14:31:38 UTC) #22
Yaron
https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java (right): https://codereview.chromium.org/2956193002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java#newcode192 chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java:192: // name. On 2017/07/11 14:31:38, pkotwicz wrote: > The ...
3 years, 5 months ago (2017-07-12 16:54:01 UTC) #23
pkotwicz
Yaron, can you please take another look? I moved the logic to the shell APK ...
3 years, 5 months ago (2017-07-23 01:46:10 UTC) #24
Yaron
lgtm https://codereview.chromium.org/2956193002/diff/60001/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java File chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java (right): https://codereview.chromium.org/2956193002/diff/60001/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java#newcode95 chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:95: // scheme and host name. nit: there's an ...
3 years, 5 months ago (2017-07-24 15:09:18 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956193002/120001
3 years, 4 months ago (2017-07-28 03:29:06 UTC) #28
commit-bot: I haz the power
3 years, 4 months ago (2017-07-28 05:07:41 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6c7ac7c0265c50a2da530c21f040...

Powered by Google App Engine
This is Rietveld 408576698