Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(98)

Issue 2954903002: Media track ID visibility at BWE level

Created:
5 months, 2 weeks ago by alexnarest
Modified:
2 months, 2 weeks ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds media track ID visibility at bitrate allocator level. Track IDs are assigned by application during track creation. Track IDs are used by custom bitrate allocation strategies to identify tracks. Track ID can be empty, in that case bitrate allocation strategies will not be able to handle these tracks specifically and will handle them as a default. BUG=webrtc:8243

Patch Set 1 : Media track ID visibility at BWE level #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M webrtc/audio/audio_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/audio_send_stream.h View 1 chunk +3 lines, -0 lines 2 comments Download
M webrtc/call/bitrate_allocator.h View 4 chunks +8 lines, -3 lines 2 comments Download
M webrtc/call/bitrate_allocator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ARDAppClient.m View 3 chunks +9 lines, -21 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 3 chunks +3 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M webrtc/video_send_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
Trybot results:

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
stefan-webrtc
To better understand how the trackid is going to be used it would be used ...
5 months, 2 weeks ago (2017-06-27 07:37:18 UTC) #3
alexnarest
This is a prequel to https://codereview.webrtc.org/2996643002/ PTAL
2 months, 4 weeks ago (2017-09-15 14:58:54 UTC) #10
Taylor Brandstetter
lgtm
2 months, 3 weeks ago (2017-09-16 00:47:48 UTC) #11
nisse-webrtc
lgtm In cl description, reference to "dependent cls" is not very helpful. Delete, and it ...
2 months, 3 weeks ago (2017-09-18 08:44:29 UTC) #12
alexnarest
Description updated. https://codereview.webrtc.org/2954903002/diff/60001/webrtc/call/audio_send_stream.h File webrtc/call/audio_send_stream.h (right): https://codereview.webrtc.org/2954903002/diff/60001/webrtc/call/audio_send_stream.h#newcode128 webrtc/call/audio_send_stream.h:128: std::string track_id; On 2017/09/18 08:44:28, nisse-webrtc wrote: ...
2 months, 2 weeks ago (2017-09-29 12:13:57 UTC) #17
stefan-webrtc
lgtm
2 months, 2 weeks ago (2017-09-29 12:19:34 UTC) #18
nisse-webrtc
2 months, 2 weeks ago (2017-09-29 12:32:47 UTC) #19
lgtm

Powered by Google App Engine
This is Rietveld 0eb02b776