Adds video-surface feature switch.

Adds video-surface feature switch.

BUG=726619
Review-Url: https://codereview.chromium.org/2954773002
Cr-Commit-Position: refs/heads/master@{#483529}
Committed: https://chromium.googlesource.com/chromium/src/+/7cae48adba74979cd6290a4b7317e01926ef0eb1

[CJ, 2017-06-23 22:10:07]

Description was changed from

==========
Adds video-surface feature switch.

BUG=726619
==========

to

==========
Adds video-surface feature switch.

BUG=726619
==========

[CJ, 2017-06-23 22:10:07]

lethalantidote@chromium.org changed reviewers:
+ apacible@chromium.org, isherman@chromium.org, mlamouri@chromium.org

[Ilya Sherman, 2017-06-26 14:52:05]

I don't think you need my review for this change.

[CJ, 2017-06-26 18:03:13]

On 2017/06/26 14:52:05, Ilya Sherman wrote:
> I don't think you need my review for this change.

Sorry about that, must have been looking at the wrong owners file.

[CJ, 2017-06-26 18:04:18]

lethalantidote@chromium.org changed reviewers:
+ liberato@chromium.org
- isherman@chromium.org

[CJ, 2017-06-26 18:04:18]

-Ilya Sherman

+liberato OWNERS

[Ilya Sherman, 2017-06-26 18:04:20]

isherman@chromium.org changed reviewers:
- liberato@chromium.org

[Ilya Sherman, 2017-06-26 18:08:19]

isherman@chromium.org changed reviewers:
+ liberato@chromium.org

[liberato (no reviews please), 2017-06-26 22:13:34]

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.cc
File media/base/media_switches.cc (right):

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.c...
media/base/media_switches.cc:247: const base::Feature
kVideoSurface{"video-surface",
most of these are of the form "verb-thing".  maybe "use-surface-for-video" or
something like that?

'surface' is pretty overloaded too.  i have no idea what to call it that's
better.  if you also do not, then 'surface' it must be....

[DaleCurtis, 2017-06-26 23:07:26]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2017-06-26 23:07:27]

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.cc
File media/base/media_switches.cc (right):

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.c...
media/base/media_switches.cc:247: const base::Feature
kVideoSurface{"video-surface",
On 2017/06/26 at 22:13:34, liberato wrote:
> most of these are of the form "verb-thing".  maybe "use-surface-for-video" or
something like that?
> 
> 'surface' is pretty overloaded too.  i have no idea what to call it that's
better.  if you also do not, then 'surface' it must be....

Despite the mixed style usage in this file, the preferred style is VideoSurface.
On naming, being explicit never huts how about UseSurfaceLayerForVideo ? :)

[CJ, 2017-06-27 17:56:02]

Updated. PTAL

[DaleCurtis, 2017-06-27 17:58:12]

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.cc
File media/base/media_switches.cc (right):

https://codereview.chromium.org/2954773002/diff/1/media/base/media_switches.c...
media/base/media_switches.cc:247: const base::Feature
kVideoSurface{"video-surface",
On 2017/06/26 at 23:07:27, DaleCurtis wrote:
> On 2017/06/26 at 22:13:34, liberato wrote:
> > most of these are of the form "verb-thing".  maybe "use-surface-for-video"
or something like that?
> > 
> > 'surface' is pretty overloaded too.  i have no idea what to call it that's
better.  if you also do not, then 'surface' it must be....
> 
> Despite the mixed style usage in this file, the preferred style is
VideoSurface. On naming, being explicit never huts how about
UseSurfaceLayerForVideo ? :)

Sorry this wasn't clear, the naming style must be CamelCase despite the issues
earlier in this file.

[mlamouri (slow - plz ping), 2017-06-27 18:22:07]

lgtm with the name changed to UseSurfaceLayerForVideo.

[CJ, 2017-06-29 20:00:39]

Switched to CamelCase. PTAL

[liberato (no reviews please), 2017-06-29 20:05:55]

On 2017/06/29 20:00:39, CJ wrote:
> Switched to CamelCase. PTAL

Lgtm

-fl

[DaleCurtis, 2017-06-29 20:09:17]

lgtm

[CJ, 2017-06-29 20:36:49]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2017-06-29 20:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2954773002/#ps40001
(title: "Switch to CamelCase.")

[commit-bot: I haz the power, 2017-06-29 20:37:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[apacible, 2017-06-29 20:37:53]

lgtm

[commit-bot: I haz the power, 2017-06-29 22:56:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498768609017650,
"parent_rev": "aeab1ab6a74ae5ad43d2397d305d249040f26b64", "commit_rev":
"7cae48adba74979cd6290a4b7317e01926ef0eb1"}

[commit-bot: I haz the power, 2017-06-29 22:56:31]

Description was changed from

==========
Adds video-surface feature switch.

BUG=726619
==========

to

==========
Adds video-surface feature switch.

BUG=726619

Review-Url: https://codereview.chromium.org/2954773002
Cr-Commit-Position: refs/heads/master@{#483529}
Committed:
https://chromium.googlesource.com/chromium/src/+/7cae48adba74979cd6290a4b7317...
==========

[commit-bot: I haz the power, 2017-06-29 22:56:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7cae48adba74979cd6290a4b7317...