[MarkersInter...Range #2-9] Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181
Review-Url: https://codereview.chromium.org/2954763002
Cr-Commit-Position: refs/heads/master@{#488476}
Committed: https://chromium.googlesource.com/chromium/src/+/37f9a3079589e85e24eaa5849235b7eedc9fd0ab

[rlanday, 2017-06-23 22:09:43]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-23 22:09:59]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-06-23 22:10:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-23 22:10:36]

Description was changed from

==========
Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

BUG=736181
==========

to

==========
Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181
==========

[commit-bot: I haz the power, 2017-06-24 00:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-24 00:22:50]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-06-26 21:06:52]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 21:07:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-06-26 22:44:33]

lgtm

[commit-bot: I haz the power, 2017-06-26 23:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 23:11:40]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-07-05 17:55:01]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 17:55:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-07-07 19:54:49]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 19:56:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 21:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 21:49:15]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-07-11 19:54:22]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 19:54:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-11 22:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 22:42:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[rlanday, 2017-07-12 23:59:28]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 23:59:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 01:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-13 01:25:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-07-20 01:13:22]

lgtm

[rlanday, 2017-07-20 18:42:39]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-07-20 18:42:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org, yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2954763002/#ps120001
(title: "Remove dependency")

[commit-bot: I haz the power, 2017-07-20 18:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 18:43:16]

This CL has an open dependency (Issue 2960473002 Patch 160001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rlanday, 2017-07-20 18:47:05]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-07-20 18:47:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2954763002/#ps140001
(title: "Actually remove dependency")

[commit-bot: I haz the power, 2017-07-20 18:47:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 20:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-20 20:49:50]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rlanday, 2017-07-20 21:24:17]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-07-20 21:24:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-20 23:17:20]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1500585857765110,
"parent_rev": "4d1f330a1d46c31548b9d0319712daf5b0a16e1f", "commit_rev":
"37f9a3079589e85e24eaa5849235b7eedc9fd0ab"}

[commit-bot: I haz the power, 2017-07-20 23:17:41]

Description was changed from

==========
Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181
==========

to

==========
Change behavior of SpellChecker::GetSpellCheckMarkerTouchingSelection()

When I added this method, I had added some extra logic for the case where we
have a collapsed selection to make it find spell check markers the caret is
touching an endpoint of. This was to support the spell check menu on Android,
where tapping the endpoint of a word brings up the menu (on other platforms you
need to right-click in the interior of the word for spell check options to
appear in the context menu).

Upon further reflection, we decided we should put this logic somewhere else.
We're going to keep this method around though because we're going to make use of
it in ContextMenuClient::SelectMisspellingAsync().

I'm renaming this method to GetSpellCheckMarkerUnderSelection() to try to make
the name less misleading.

BUG=736181

Review-Url: https://codereview.chromium.org/2954763002
Cr-Commit-Position: refs/heads/master@{#488476}
Committed:
https://chromium.googlesource.com/chromium/src/+/37f9a3079589e85e24eaa5849235...
==========

[commit-bot: I haz the power, 2017-07-20 23:17:43]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/37f9a3079589e85e24eaa5849235...