[DevTools] Migrate inspector-protocol/runtime tests to new harness

[DevTools] Migrate inspector-protocol/runtime tests to new harness

BUG=734762
Review-Url: https://codereview.chromium.org/2954093003
Cr-Commit-Position: refs/heads/master@{#482493}
Committed: https://chromium.googlesource.com/chromium/src/+/9ea908c1131b2a88c1976f9c9af16577a84a11c4

[dgozman, 2017-06-23 21:32:04]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2017-06-23 21:32:05]

Could you please take a look?

[dgozman, 2017-06-23 21:32:29]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 21:32:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 21:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 21:36:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2017-06-23 22:12:11]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 22:12:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 23:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 23:24:51]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-06-26 21:57:27]

dgozman@chromium.org changed reviewers:
+ einbinder@chromium.org

[dgozman, 2017-06-26 21:57:27]

+Joel

[einbinder, 2017-06-26 22:59:23]

lgtm

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:133:
this.log(message);
"Fail:" +

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.js:2:
let {page, session, dp} = await testRunner.startBlank(``);
If there is going to be a blank line, might as well have a description

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate.txt
(left):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate.txt:1:
CONSOLE MESSAGE: line 13:
This file wasn't being used right? I don't see a reference to it anywhere.

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.js:14:
console.log(memory.constructor.constructor('return
document.querySelector("#mydiv").textContent')());
The constructor is a function, so constructor.constructor is Function? What is
this testing?

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-shouldnt-crash-after-inspected-context-destroyed-expected.txt
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-shouldnt-crash-after-inspected-context-destroyed-expected.txt:2:
{
This is logged to verify that the command actually ran/didn't produce a result?

[dgozman, 2017-06-26 23:28:55]

Thanks for review!

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/resources/inspector-protocol-test.js:133:
this.log(message);
On 2017/06/26 22:59:23, einbinder wrote:
> "Fail:" + 

Done.

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.js:2:
let {page, session, dp} = await testRunner.startBlank(``);
On 2017/06/26 22:59:23, einbinder wrote:
> If there is going to be a blank line, might as well have a description

Yeah, I am going to follow up with mass-adding descriptions to the tests which
lack one.

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate.txt
(left):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-log-handle-navigate.txt:1:
CONSOLE MESSAGE: line 13:
On 2017/06/26 22:59:23, einbinder wrote:
> This file wasn't being used right? I don't see a reference to it anywhere.

Yeah, that's someone being not accurate with git :)

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.js
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.js:14:
console.log(memory.constructor.constructor('return
document.querySelector("#mydiv").textContent')());
On 2017/06/26 22:59:23, einbinder wrote:
> The constructor is a function, so constructor.constructor is Function? What is
> this testing?

I have no idea, but I preserved the original code.

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-shouldnt-crash-after-inspected-context-destroyed-expected.txt
(right):

https://codereview.chromium.org/2954093003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-shouldnt-crash-after-inspected-context-destroyed-expected.txt:2:
{
On 2017/06/26 22:59:23, einbinder wrote:
> This is logged to verify that the command actually ran/didn't produce a
result?

Yeah, this is to check that we got response.

[dgozman, 2017-06-26 23:29:27]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-06-26 23:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
einbinder@chromium.org
Link to the patchset: https://codereview.chromium.org/2954093003/#ps40001
(title: "fail:")

[commit-bot: I haz the power, 2017-06-26 23:29:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 00:51:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498519767970660,
"parent_rev": "43eb70f8c3b14a54f5b8a2f9ccb06236a70b0c82", "commit_rev":
"9ea908c1131b2a88c1976f9c9af16577a84a11c4"}

[commit-bot: I haz the power, 2017-06-27 00:52:01]

Description was changed from

==========
[DevTools] Migrate inspector-protocol/runtime tests to new harness

BUG=734762
==========

to

==========
[DevTools] Migrate inspector-protocol/runtime tests to new harness

BUG=734762

Review-Url: https://codereview.chromium.org/2954093003
Cr-Commit-Position: refs/heads/master@{#482493}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ea908c1131b2a88c1976f9c9af1...
==========

[commit-bot: I haz the power, 2017-06-27 00:52:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9ea908c1131b2a88c1976f9c9af1...