Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2953793002: Run cl format on audio_device_pulse_linux.cc. (Closed)

Created:
3 years, 6 months ago by saza WebRTC
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run cl format on audio_device_pulse_linux.cc. Occurrences of WEBRTC_TRACE(...) will in the future be replaced with the preferred logging mechanism LOG(...). That will be done with a script that runs 'git cl format' on diffs, which will break formatting of surrounding code if the file is not already formatted. Hence this CL. BUG=webrtc:5118 Review-Url: https://codereview.webrtc.org/2953793002 Cr-Commit-Position: refs/heads/master@{#18766} Committed: https://chromium.googlesource.com/external/webrtc/+/b89f300e034f216d5df955efba37630aaf143b58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1881 lines, -2288 lines) Patch
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc View 5 chunks +1881 lines, -2288 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
saza WebRTC
Please take a look at this formatting change.
3 years, 6 months ago (2017-06-22 13:18:57 UTC) #6
Henrik Grunell WebRTC
The diff is too misaligned to properly review. What I did instead was to apply ...
3 years, 5 months ago (2017-06-26 12:47:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2953793002/1
3 years, 5 months ago (2017-06-26 13:33:22 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 14:01:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b89f300e034f216d5df955efb...

Powered by Google App Engine
This is Rietveld 408576698