Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2953053002: Reland of Periodically update codec bit/frame rate settings. (Closed)

Created:
3 years, 6 months ago by sprang_webrtc
Modified:
3 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Periodically update codec bit/frame rate settings. Patch set 1 is a reland + trivial rebase. Patch set >= 2 contains bug fixes. > Original issue's description: > > Fix bug in vie_encoder.cc which caused channel parameters not to be updated at regular intervals, as it was intended. > > > > That however exposes a bunch of failed test, so this CL also fixed a few other things: > > * FakeEncoder should trust the configured FPS value rather than guesstimating itself based on the realtime clock, so as not to completely undershoot targets in offline mode. Also, compensate for key-frame overshoots when outputting delta frames. > > * FrameDropper should not assuming incoming frame rate is 0 if no frames have been seen. > > * Fix a bunch of test cases that started failing because they were relying on the fake encoder undershooting. > > * Fix test > > > > BUG=7664 > > > > Review-Url: https://codereview.webrtc.org/2883963002 > > Cr-Commit-Position: refs/heads/master@{#18473} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6431e21da672a5f3bbf166d3d4d98b171d015706 BUG=webrtc:7664 Review-Url: https://codereview.webrtc.org/2953053002 Cr-Commit-Position: refs/heads/master@{#18782} Committed: https://chromium.googlesource.com/external/webrtc/+/4847ae6b51ea55b9db9bf16c7b97c3cb8d000f23

Patch Set 1 #

Patch Set 2 : Fix bug and add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -297 lines) Patch
M webrtc/call/rampup_tests.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/simulcast.cc View 4 chunks +35 lines, -65 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 1 chunk +7 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 4 chunks +18 lines, -9 lines 0 comments Download
M webrtc/test/fake_encoder.h View 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 7 chunks +48 lines, -36 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 2 chunks +34 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 125 chunks +309 lines, -181 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
sprang_webrtc
3 years, 5 months ago (2017-06-26 14:54:24 UTC) #8
stefan-webrtc
lgtm
3 years, 5 months ago (2017-06-27 07:33:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2953053002/20001
3 years, 5 months ago (2017-06-27 14:04:54 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 14:07:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/4847ae6b51ea55b9db9bf16c7...

Powered by Google App Engine
This is Rietveld 408576698