Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 2951273002: Disable RTCVideoRenderFrameCallbackNV12 test (Closed)

Created:
3 years, 6 months ago by oprypin_webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable RTCVideoRenderFrameCallbackNV12 test It has been crashing on trybots BUG=webrtc:7863 TBR=magjed@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2951273002 Cr-Commit-Position: refs/heads/master@{#18720} Committed: https://chromium.googlesource.com/external/webrtc/+/4d25a0554a4bde9d76de5f3728fa181ba82fb0e1

Patch Set 1 : Disable RTCVideoRenderFrameCallbackNV12 test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
oprypin_webrtc
Please review this change. Sorry for sending review before trybots have finished.
3 years, 6 months ago (2017-06-22 14:05:00 UTC) #4
kjellander_webrtc
Thanks for creating this. I suggest TBRing this as I was already hit at https://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/5445 ...
3 years, 6 months ago (2017-06-22 14:36:07 UTC) #7
oprypin_webrtc
The iOS bots have too big of a queue to try this any time soon ...
3 years, 6 months ago (2017-06-22 15:09:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2951273002/20001
3 years, 6 months ago (2017-06-22 15:16:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/4d25a0554a4bde9d76de5f3728fa181ba82fb0e1
3 years, 6 months ago (2017-06-22 15:19:07 UTC) #13
magjed_webrtc
3 years, 5 months ago (2017-06-26 09:34:54 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.webrtc.org/2959673002/ by magjed@webrtc.org.

The reason for reverting is: Test has been fixed..

Powered by Google App Engine
This is Rietveld 408576698