Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2950503002: [media-internals] Add note to clipboard dialog (Closed)

Created:
3 years, 6 months ago by rongjie
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[media-internals] Add note to clipboard dialog BUG=734524 Review-Url: https://codereview.chromium.org/2950503002 Cr-Commit-Position: refs/heads/master@{#488866} Committed: https://chromium.googlesource.com/chromium/src/+/a6fb6c2e7e8b6aa98ad097d44e0aed5eeb9ca220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/resources/media/media_internals.css View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rongjie
PTAL
3 years, 6 months ago (2017-06-19 13:17:18 UTC) #2
tommi (sloooow) - chröme
Henrik - can you take a look?
3 years, 6 months ago (2017-06-19 13:30:13 UTC) #5
Henrik Grunell
I think this should be enough. lgtm.
3 years, 6 months ago (2017-06-20 08:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950503002/1
3 years, 6 months ago (2017-06-21 09:36:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/469666)
3 years, 6 months ago (2017-06-21 09:43:51 UTC) #10
rongjie
Ping tommi@
3 years, 6 months ago (2017-06-21 11:07:30 UTC) #11
rongjie
On 2017/06/21 11:07:30, rongjie wrote: > Ping tommi@ tommi@, another ping, or should I move ...
3 years, 5 months ago (2017-07-22 12:16:06 UTC) #12
tommi (sloooow) - chröme
lgtm Sorry, for some reason I had not seen this.
3 years, 5 months ago (2017-07-22 13:38:48 UTC) #13
tommi (sloooow) - chröme
On 2017/07/22 13:38:48, tommi (sloooow) - chröme wrote: > lgtm > > Sorry, for some ...
3 years, 5 months ago (2017-07-22 13:40:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950503002/1
3 years, 5 months ago (2017-07-22 13:48:01 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-22 19:11:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6fb6c2e7e8b6aa98ad097d44e0a...

Powered by Google App Engine
This is Rietveld 408576698