Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2949203002: Only use 95% of the link capacity if the true link capacity is found by probing. (Closed)

Created:
3 years, 6 months ago by terelius
Modified:
3 years, 5 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only use 95% of the link capacity if the true link capacity is found by probing. Dont do a normal AimdRateControlUpdate update after a probe. Only set result.updated if the bitrate estimate has changed. BUG=webrtc:7866 Review-Url: https://codereview.webrtc.org/2949203002 Cr-Commit-Position: refs/heads/master@{#18785} Committed: https://chromium.googlesource.com/external/webrtc/+/376473054ca704922da2412ec82d49d4902d2e4f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 5 chunks +9 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.cc View 1 4 chunks +22 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc View 6 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
terelius
3 years, 6 months ago (2017-06-22 12:42:57 UTC) #4
philipel
lgtm with nit https://codereview.webrtc.org/2949203002/diff/1/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc File webrtc/modules/congestion_controller/probe_bitrate_estimator.cc (right): https://codereview.webrtc.org/2949203002/diff/1/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc#newcode153 webrtc/modules/congestion_controller/probe_bitrate_estimator.cc:153: // case, set the target bitrate ...
3 years, 6 months ago (2017-06-22 13:38:59 UTC) #7
terelius
https://codereview.webrtc.org/2949203002/diff/1/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc File webrtc/modules/congestion_controller/probe_bitrate_estimator.cc (right): https://codereview.webrtc.org/2949203002/diff/1/webrtc/modules/congestion_controller/probe_bitrate_estimator.cc#newcode153 webrtc/modules/congestion_controller/probe_bitrate_estimator.cc:153: // case, set the target bitrate slightly lower to ...
3 years, 6 months ago (2017-06-22 14:04:46 UTC) #8
stefan-webrtc
lgtm
3 years, 5 months ago (2017-06-27 13:09:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2949203002/20001
3 years, 5 months ago (2017-06-27 13:18:48 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 14:50:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/376473054ca704922da2412ec...

Powered by Google App Engine
This is Rietveld 408576698