Allow an external audio processing module to be used in WebRTC

[This CL is a rebase of an original CL by peah@: https://chromium-review.googlesource.com/c/527032/]

Allow an external audio processing module to be used in WebRTC

This CL adds support for optionally using an externally created audio
processing module in a peerconnection. The ownership is shared
between the peerconnection and the external creator of the module.

As part of this the internal ownership of the audio processing module
is moved from VoiceEngine to WebRtcVoiceEngine.

BUG=webrtc:7775

[the sun, 2017-06-21 12:20:30]

Description was changed from

==========
WIP

BUG=
==========

to

==========
[This CL is a rebase of an original CL by peah@:
https://chromium-review.googlesource.com/c/527032/]

Allow an external audio processing module to be used in WebRTC

This CL adds support for optionally using an externally created audio
processing module in a peerconnection. The ownership is shared
between the peerconnection and the external creator of the module.

As part of this the internal ownership of the audio processing module
is moved from VoiceEngine to WebRtcVoiceEngine.

BUG=webrtc:7775
==========

[the sun, 2017-06-21 12:20:31]

solenberg@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, henrik.lundin@webrtc.org, holmer@google.com,
sprang@webrtc.org

[the sun, 2017-06-21 12:42:09]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 12:42:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-21 13:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 13:11:10]

Dry run: This issue passed the CQ dry run.

[the sun, 2017-06-22 08:01:06]

Rebase of Per's CL.

[Taylor Brandstetter, 2017-06-25 19:13:13]

lgtm for api, pc, ortc and media directories

https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
webrtc/media/engine/webrtcvoiceengine.cc:344: MakeAudioStateConfig(voe(),
audio_mixer_, apm_));
nit: Should use either "apm_" or "apm()" consistently

[peah-webrtc, 2017-06-27 14:57:39]

peah@webrtc.org changed reviewers:
+ peah@webrtc.org

[peah-webrtc, 2017-06-27 14:57:40]

https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
webrtc/media/engine/webrtcvoiceengine.cc:344: MakeAudioStateConfig(voe(),
audio_mixer_, apm_));
On 2017/06/25 19:13:12, Taylor Brandstetter wrote:
> nit: Should use either "apm_" or "apm()" consistently

That does not work here, as apm() returns a AudioProcessing* pointer, and
MakeAudioStateConfig requires the scoped_refptr<AudioProcessing> which is stored
in apm_.

[Taylor Brandstetter, 2017-06-28 07:11:51]

On 2017/06/27 14:57:40, peah-webrtc wrote:
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> File webrtc/media/engine/webrtcvoiceengine.cc (right):
> 
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> webrtc/media/engine/webrtcvoiceengine.cc:344: MakeAudioStateConfig(voe(),
> audio_mixer_, apm_));
> On 2017/06/25 19:13:12, Taylor Brandstetter wrote:
> > nit: Should use either "apm_" or "apm()" consistently
> 
> That does not work here, as apm() returns a AudioProcessing* pointer, and
> MakeAudioStateConfig requires the scoped_refptr<AudioProcessing> which is
stored
> in apm_.

Aren't conversions to/from scoped_refptr implicit? Anyway, just a nit so doesn't
really matter.

[kwiberg-webrtc, 2017-06-28 09:24:00]

On 2017/06/28 07:11:51, Taylor Brandstetter wrote:
> On 2017/06/27 14:57:40, peah-webrtc wrote:
> >
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> > File webrtc/media/engine/webrtcvoiceengine.cc (right):
> > 
> >
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> > webrtc/media/engine/webrtcvoiceengine.cc:344: MakeAudioStateConfig(voe(),
> > audio_mixer_, apm_));
> > On 2017/06/25 19:13:12, Taylor Brandstetter wrote:
> > > nit: Should use either "apm_" or "apm()" consistently
> > 
> > That does not work here, as apm() returns a AudioProcessing* pointer, and
> > MakeAudioStateConfig requires the scoped_refptr<AudioProcessing> which is
> stored
> > in apm_.
> 
> Aren't conversions to/from scoped_refptr implicit? Anyway, just a nit so
doesn't
> really matter.

They are, but it makes kittens cry, so Per is right to refuse to do it! :-)

IIRC the scoped_refptr in Chromium has one of the implicit conversions removed;
on my to-do list is one item for stealing their scoped_refptr, and one item for
making it even more strict by removing the implicitness of the other direction
as well.

[hlundin-webrtc, 2017-07-03 13:28:05]

On 2017/06/28 09:24:00, kwiberg-webrtc wrote:
> On 2017/06/28 07:11:51, Taylor Brandstetter wrote:
> > On 2017/06/27 14:57:40, peah-webrtc wrote:
> > >
> >
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> > > File webrtc/media/engine/webrtcvoiceengine.cc (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/2948763002/diff/160001/webrtc/media/engine/webr...
> > > webrtc/media/engine/webrtcvoiceengine.cc:344: MakeAudioStateConfig(voe(),
> > > audio_mixer_, apm_));
> > > On 2017/06/25 19:13:12, Taylor Brandstetter wrote:
> > > > nit: Should use either "apm_" or "apm()" consistently
> > > 
> > > That does not work here, as apm() returns a AudioProcessing* pointer, and
> > > MakeAudioStateConfig requires the scoped_refptr<AudioProcessing> which is
> > stored
> > > in apm_.
> > 
> > Aren't conversions to/from scoped_refptr implicit? Anyway, just a nit so
> doesn't
> > really matter.
> 
> They are, but it makes kittens cry, so Per is right to refuse to do it! :-)
> 
> IIRC the scoped_refptr in Chromium has one of the implicit conversions
removed;
> on my to-do list is one item for stealing their scoped_refptr, and one item
for
> making it even more strict by removing the implicitness of the other direction
> as well.

I suppose this CL is dead now that https://codereview.webrtc.org/2961723004 has
landed.
Please, don't delete this CL; simply close it, since the landed one refers to
this.