Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: webrtc/voice_engine/voe_network_unittest.cc

Issue 2948763002: Allow an external audio processing module to be used in WebRTC (Closed)
Patch Set: tracking linux32_rel issue Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 // A packet with a valid header for both RTP and RTCP. 25 // A packet with a valid header for both RTP and RTCP.
26 // Methods that are tested in this file are checking only packet header. 26 // Methods that are tested in this file are checking only packet header.
27 static const uint8_t kPacket[kMinValidSizeOfRtpPacketInBytes] = {0x80}; 27 static const uint8_t kPacket[kMinValidSizeOfRtpPacketInBytes] = {0x80};
28 static const uint8_t kPacketJunk[kMinValidSizeOfRtpPacketInBytes] = {}; 28 static const uint8_t kPacketJunk[kMinValidSizeOfRtpPacketInBytes] = {};
29 29
30 static const int kNonExistingChannel = 1234; 30 static const int kNonExistingChannel = 1234;
31 31
32 class VoENetworkTest : public VoiceEngineFixture { 32 class VoENetworkTest : public VoiceEngineFixture {
33 protected: 33 protected:
34 int CreateChannelAndRegisterExternalTransport() { 34 int CreateChannelAndRegisterExternalTransport() {
35 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 35 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
36 int channelID = base_->CreateChannel(); 36 int channelID = base_->CreateChannel();
37 EXPECT_NE(channelID, -1); 37 EXPECT_NE(channelID, -1);
38 EXPECT_EQ(0, network_->RegisterExternalTransport(channelID, transport_)); 38 EXPECT_EQ(0, network_->RegisterExternalTransport(channelID, transport_));
39 return channelID; 39 return channelID;
40 } 40 }
41 }; 41 };
42 42
43 TEST_F(VoENetworkTest, RegisterAndDeRegisterExternalTransport) { 43 TEST_F(VoENetworkTest, RegisterAndDeRegisterExternalTransport) {
44 int channelID = CreateChannelAndRegisterExternalTransport(); 44 int channelID = CreateChannelAndRegisterExternalTransport();
45 EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID)); 45 EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID));
46 } 46 }
47 47
48 TEST_F(VoENetworkTest, 48 TEST_F(VoENetworkTest,
49 RegisterExternalTransportOnNonExistingChannelShouldFail) { 49 RegisterExternalTransportOnNonExistingChannelShouldFail) {
50 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 50 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
51 EXPECT_NE( 51 EXPECT_NE(
52 0, network_->RegisterExternalTransport(kNonExistingChannel, transport_)); 52 0, network_->RegisterExternalTransport(kNonExistingChannel, transport_));
53 } 53 }
54 54
55 TEST_F(VoENetworkTest, 55 TEST_F(VoENetworkTest,
56 DeRegisterExternalTransportOnNonExistingChannelShouldFail) { 56 DeRegisterExternalTransportOnNonExistingChannelShouldFail) {
57 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 57 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
58 EXPECT_NE(0, network_->DeRegisterExternalTransport(kNonExistingChannel)); 58 EXPECT_NE(0, network_->DeRegisterExternalTransport(kNonExistingChannel));
59 } 59 }
60 60
61 TEST_F(VoENetworkTest, DeRegisterExternalTransportBeforeRegister) { 61 TEST_F(VoENetworkTest, DeRegisterExternalTransportBeforeRegister) {
62 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 62 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
63 int channelID = base_->CreateChannel(); 63 int channelID = base_->CreateChannel();
64 EXPECT_NE(channelID, -1); 64 EXPECT_NE(channelID, -1);
65 EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID)); 65 EXPECT_EQ(0, network_->DeRegisterExternalTransport(channelID));
66 } 66 }
67 67
68 TEST_F(VoENetworkTest, ReceivedRTPPacketWithJunkDataShouldFail) { 68 TEST_F(VoENetworkTest, ReceivedRTPPacketWithJunkDataShouldFail) {
69 int channelID = CreateChannelAndRegisterExternalTransport(); 69 int channelID = CreateChannelAndRegisterExternalTransport();
70 EXPECT_EQ(-1, network_->ReceivedRTPPacket(channelID, kPacketJunk, 70 EXPECT_EQ(-1, network_->ReceivedRTPPacket(channelID, kPacketJunk,
71 sizeof(kPacketJunk))); 71 sizeof(kPacketJunk)));
72 } 72 }
73 73
74 TEST_F(VoENetworkTest, ReceivedRTPPacketOnNonExistingChannelShouldFail) { 74 TEST_F(VoENetworkTest, ReceivedRTPPacketOnNonExistingChannelShouldFail) {
75 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 75 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
76 EXPECT_EQ(-1, network_->ReceivedRTPPacket(kNonExistingChannel, kPacket, 76 EXPECT_EQ(-1, network_->ReceivedRTPPacket(kNonExistingChannel, kPacket,
77 sizeof(kPacket))); 77 sizeof(kPacket)));
78 } 78 }
79 79
80 TEST_F(VoENetworkTest, ReceivedRTPPacketOnChannelWithoutTransportShouldFail) { 80 TEST_F(VoENetworkTest, ReceivedRTPPacketOnChannelWithoutTransportShouldFail) {
81 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 81 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
82 int channelID = base_->CreateChannel(); 82 int channelID = base_->CreateChannel();
83 EXPECT_NE(channelID, -1); 83 EXPECT_NE(channelID, -1);
84 EXPECT_EQ(-1, 84 EXPECT_EQ(-1,
85 network_->ReceivedRTPPacket(channelID, kPacket, sizeof(kPacket))); 85 network_->ReceivedRTPPacket(channelID, kPacket, sizeof(kPacket)));
86 } 86 }
87 87
88 TEST_F(VoENetworkTest, ReceivedTooSmallRTPPacketShouldFail) { 88 TEST_F(VoENetworkTest, ReceivedTooSmallRTPPacketShouldFail) {
89 int channelID = CreateChannelAndRegisterExternalTransport(); 89 int channelID = CreateChannelAndRegisterExternalTransport();
90 EXPECT_EQ(-1, network_->ReceivedRTPPacket( 90 EXPECT_EQ(-1, network_->ReceivedRTPPacket(
91 channelID, kPacket, kMinValidSizeOfRtpPacketInBytes - 1)); 91 channelID, kPacket, kMinValidSizeOfRtpPacketInBytes - 1));
92 } 92 }
93 93
94 TEST_F(VoENetworkTest, ReceivedTooLargeRTPPacketShouldFail) { 94 TEST_F(VoENetworkTest, ReceivedTooLargeRTPPacketShouldFail) {
95 int channelID = CreateChannelAndRegisterExternalTransport(); 95 int channelID = CreateChannelAndRegisterExternalTransport();
96 EXPECT_EQ(-1, network_->ReceivedRTPPacket( 96 EXPECT_EQ(-1, network_->ReceivedRTPPacket(
97 channelID, kPacket, kMaxValidSizeOfRtpPacketInBytes + 1)); 97 channelID, kPacket, kMaxValidSizeOfRtpPacketInBytes + 1));
98 } 98 }
99 99
100 TEST_F(VoENetworkTest, ReceivedRTCPPacketWithJunkDataShouldFail) { 100 TEST_F(VoENetworkTest, ReceivedRTCPPacketWithJunkDataShouldFail) {
101 int channelID = CreateChannelAndRegisterExternalTransport(); 101 int channelID = CreateChannelAndRegisterExternalTransport();
102 EXPECT_EQ(0, network_->ReceivedRTCPPacket(channelID, kPacketJunk, 102 EXPECT_EQ(0, network_->ReceivedRTCPPacket(channelID, kPacketJunk,
103 sizeof(kPacketJunk))); 103 sizeof(kPacketJunk)));
104 EXPECT_EQ(VE_SOCKET_TRANSPORT_MODULE_ERROR, base_->LastError()); 104 EXPECT_EQ(VE_SOCKET_TRANSPORT_MODULE_ERROR, base_->LastError());
105 } 105 }
106 106
107 TEST_F(VoENetworkTest, ReceivedRTCPPacketOnNonExistingChannelShouldFail) { 107 TEST_F(VoENetworkTest, ReceivedRTCPPacketOnNonExistingChannelShouldFail) {
108 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 108 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
109 EXPECT_EQ(-1, network_->ReceivedRTCPPacket(kNonExistingChannel, kPacket, 109 EXPECT_EQ(-1, network_->ReceivedRTCPPacket(kNonExistingChannel, kPacket,
110 sizeof(kPacket))); 110 sizeof(kPacket)));
111 } 111 }
112 112
113 TEST_F(VoENetworkTest, ReceivedRTCPPacketOnChannelWithoutTransportShouldFail) { 113 TEST_F(VoENetworkTest, ReceivedRTCPPacketOnChannelWithoutTransportShouldFail) {
114 EXPECT_EQ(0, base_->Init(&adm_, nullptr)); 114 EXPECT_EQ(0, base_->Init(&adm_, apm_.get(), nullptr));
115 int channelID = base_->CreateChannel(); 115 int channelID = base_->CreateChannel();
116 EXPECT_NE(channelID, -1); 116 EXPECT_NE(channelID, -1);
117 EXPECT_EQ(-1, 117 EXPECT_EQ(-1,
118 network_->ReceivedRTCPPacket(channelID, kPacket, sizeof(kPacket))); 118 network_->ReceivedRTCPPacket(channelID, kPacket, sizeof(kPacket)));
119 } 119 }
120 120
121 TEST_F(VoENetworkTest, ReceivedTooSmallRTCPPacket4ShouldFail) { 121 TEST_F(VoENetworkTest, ReceivedTooSmallRTCPPacket4ShouldFail) {
122 int channelID = CreateChannelAndRegisterExternalTransport(); 122 int channelID = CreateChannelAndRegisterExternalTransport();
123 EXPECT_EQ(-1, network_->ReceivedRTCPPacket( 123 EXPECT_EQ(-1, network_->ReceivedRTCPPacket(
124 channelID, kPacket, kMinValidSizeOfRtcpPacketInBytes - 1)); 124 channelID, kPacket, kMinValidSizeOfRtcpPacketInBytes - 1));
125 } 125 }
126 126
127 } // namespace webrtc 127 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698