webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h - Issue 2947633003: Allow parsing empty RTCP TargetBitrate messages, but stop sending them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

Issue 2947633003: Allow parsing empty RTCP TargetBitrate messages, but stop sending them. (Closed)

Patch Set: Add comment about using ToString only in tests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

index d3f672a1924f707fbe30d955b5ac091f32cc40a6..d7c49a9a442b0b7514b07bd7dfe595292b0d017f 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

@@ -45,7 +45,7 @@ class TargetBitrate {

const std::vector<BitrateItem>& GetTargetBitrates() const;

- bool Parse(const uint8_t* block, uint16_t block_length);

+ void Parse(const uint8_t* block, uint16_t block_length);

size_t BlockLength() const;