Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/target_bitrate.h

Issue 2947633003: Allow parsing empty RTCP TargetBitrate messages, but stop sending them. (Closed)
Patch Set: Add comment about using ToString only in tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 38
39 TargetBitrate(); 39 TargetBitrate();
40 ~TargetBitrate(); 40 ~TargetBitrate();
41 41
42 void AddTargetBitrate(uint8_t spatial_layer, 42 void AddTargetBitrate(uint8_t spatial_layer,
43 uint8_t temporal_layer, 43 uint8_t temporal_layer,
44 uint32_t target_bitrate_kbps); 44 uint32_t target_bitrate_kbps);
45 45
46 const std::vector<BitrateItem>& GetTargetBitrates() const; 46 const std::vector<BitrateItem>& GetTargetBitrates() const;
47 47
48 bool Parse(const uint8_t* block, uint16_t block_length); 48 void Parse(const uint8_t* block, uint16_t block_length);
49 49
50 size_t BlockLength() const; 50 size_t BlockLength() const;
51 51
52 void Create(uint8_t* buffer) const; 52 void Create(uint8_t* buffer) const;
53 53
54 private: 54 private:
55 std::vector<BitrateItem> bitrates_; 55 std::vector<BitrateItem> bitrates_;
56 }; 56 };
57 57
58 } // namespace rtcp 58 } // namespace rtcp
59 } // namespace webrtc 59 } // namespace webrtc
60 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TARGET_BITRATE_H_ 60 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_TARGET_BITRATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698