Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2947563002: Revert of Opus implementation of the AudioEncoderFactoryTemplate API (Closed)

Created:
3 years, 6 months ago by charujain
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Opus implementation of the AudioEncoderFactoryTemplate API (patchset #4 id:80001 of https://codereview.webrtc.org/2930243003/ ) Reason for revert: Breaking google3 projects Original issue's description: > Opus implementation of the AudioEncoderFactoryTemplate API > > Now the templated AudioEncoderFactory can create Opus encoders! > > BUG=webrtc:7831 > > Review-Url: https://codereview.webrtc.org/2930243003 > Cr-Commit-Position: refs/heads/master@{#18645} > Committed: https://chromium.googlesource.com/external/webrtc/+/fe1aa82c63380c2f79c60cbe1f50ed13144a093f TBR=ossu@webrtc.org,solenberg@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2947563002 Cr-Commit-Position: refs/heads/master@{#18649} Committed: https://chromium.googlesource.com/external/webrtc/+/1a610f15c3f5cb88b119551cc5d5f5c23884afc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -579 lines) Patch
D webrtc/api/audio_codecs/opus/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/api/audio_codecs/opus/audio_encoder_opus.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/api/audio_codecs/opus/audio_encoder_opus.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/api/audio_codecs/opus/audio_encoder_opus_config.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/api/audio_codecs/opus/audio_encoder_opus_config.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_encoder_factory_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 6 chunks +59 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 26 chunks +153 lines, -136 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 11 chunks +96 lines, -105 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
charujain
Created Revert of Opus implementation of the AudioEncoderFactoryTemplate API
3 years, 6 months ago (2017-06-18 09:38:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2947563002/1
3 years, 6 months ago (2017-06-18 09:38:53 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-18 09:39:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1a610f15c3f5cb88b119551cc...

Powered by Google App Engine
This is Rietveld 408576698