Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2947373002: Only create H264 frames if there are no gaps in the packet sequence number. (Closed)

Created:
3 years, 6 months ago by philipel
Modified:
3 years, 6 months ago
Reviewers:
holmer, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/branch-heads/60
Project:
webrtc
Visibility:
Public.

Description

Only create H264 frames if there are no gaps in the packet sequence number. In the case of H264 we can't know which packet that is the fist packet of a frame. In order to avoid creating incomplete frames we keep track of which packets that we haven't received, and if there is a gap in the packet sequence number leading up to this frame then a frame wont be created. BUG=chromium:716558 R=holmer@google.com, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2926083002 Cr-Original-Commit-Position: refs/heads/master@{#18559} Review-Url: https://codereview.webrtc.org/2947373002 . Cr-Commit-Position: refs/branch-heads/60@{#5} Cr-Branched-From: c61bf947b4ac31f3500858ffcae6fee39d799930-refs/heads/master@{#18252} Committed: https://chromium.googlesource.com/external/webrtc/+/86c2c61b5099eaa8107b4bfd5635495055844a12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -46 lines) Patch
M webrtc/modules/video_coding/packet_buffer.h View 4 chunks +9 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer.cc View 9 chunks +78 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 6 chunks +71 lines, -43 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
philipel
Merge to M60
3 years, 6 months ago (2017-06-22 09:18:57 UTC) #2
holmer
lgtm
3 years, 6 months ago (2017-06-22 09:21:49 UTC) #4
stefan-webrtc
lgtm
3 years, 6 months ago (2017-06-22 09:25:09 UTC) #5
philipel
3 years, 6 months ago (2017-06-22 09:26:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86c2c61b5099eaa8107b4bfd5635495055844a12 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698