webrtc/pc/BUILD.gn - Issue 2947273002: Fix the binary size regression on Chromium Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/BUILD.gn

Issue 2947273002: Fix the binary size regression on Chromium Windows. (Closed)

Patch Set: Change to rtc_source_set to rtc_static_library to break the dependency from chromium.dll to opus. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/BUILD.gn

diff --git a/webrtc/pc/BUILD.gn b/webrtc/pc/BUILD.gn

index 4719db64c0a4ba73b18787d5f62c89e710c32ca6..60d76ed239c07d9a03cd09891502c6ee83e37a02 100644

--- a/webrtc/pc/BUILD.gn

+++ b/webrtc/pc/BUILD.gn

@@ -185,7 +185,7 @@ rtc_static_library("peerconnection") {

# need should use CreateModularCreatePeerConnectionFactory instead, using the

# "peerconnection" build target and other targets specific to their

# requrements. See comment in peerconnectionfactoryinterface.h.

-rtc_source_set("create_pc_factory") {

+rtc_static_library("create_pc_factory") {

sources = [

"createpeerconnectionfactory.cc",

]

« no previous file with comments | « webrtc/media/BUILD.gn ('k') | no next file » | no next file with comments »