webrtc/media/BUILD.gn - Issue 2947273002: Fix the binary size regression on Chromium Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/BUILD.gn

Issue 2947273002: Fix the binary size regression on Chromium Windows. (Closed)

Patch Set: Change to rtc_source_set to rtc_static_library to break the dependency from chromium.dll to opus. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/BUILD.gn

diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn

index ec00b049b696db4c62ac04785fb89d715fca74df..2919618b1a808eeee7704a1ce441ca77e087ec35 100644

--- a/webrtc/media/BUILD.gn

+++ b/webrtc/media/BUILD.gn

@@ -50,7 +50,7 @@ rtc_source_set("rtc_h264_profile_id") {

]

}

-rtc_source_set("rtc_media_base") {

+rtc_static_library("rtc_media_base") {

# TODO(kjellander): Remove (bugs.webrtc.org/6828)

# Enabling GN check triggers cyclic dependency error:

# //webrtc/media:rtc_media_base ->

« no previous file with comments | « no previous file | webrtc/pc/BUILD.gn » ('j') | no next file with comments »