Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2946893003: What can't loopback test be more like full stack test? (Closed)

Created:
3 years, 6 months ago by sprang_webrtc
Modified:
3 years, 6 months ago
Reviewers:
ilnik
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

What can't loopback test be more like full stack test? It can; this CL makes it a lot closer, if not all the way to a merge. Performance from video_loopback and screenshare_loopback should now match what we're seeing in FullStackTest, which will make debugging and assesment of quality differences much easier. It also adds the ability to view all of the simulcast streams at once, in separate windows. BUG=webrtc:7694 Review-Url: https://codereview.webrtc.org/2946893003 Cr-Commit-Position: refs/heads/master@{#18703} Committed: https://chromium.googlesource.com/external/webrtc/+/1168fd4ed560176987116f06f5a3bd257d471d6e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : gn fix #

Patch Set 4 : Explicit cast to make win happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -175 lines) Patch
M webrtc/video/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 4 chunks +19 lines, -4 lines 0 comments Download
M webrtc/video/video_loopback.cc View 8 chunks +97 lines, -77 lines 0 comments Download
M webrtc/video/video_quality_test.h View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 15 chunks +154 lines, -93 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
sprang_webrtc
3 years, 6 months ago (2017-06-20 14:36:15 UTC) #2
ilnik
On 2017/06/20 14:36:15, sprang_webrtc wrote: lgtm
3 years, 6 months ago (2017-06-20 15:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893003/1
3 years, 6 months ago (2017-06-21 11:29:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/5406) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 6 months ago (2017-06-21 11:31:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893003/20001
3 years, 6 months ago (2017-06-21 13:01:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/22533)
3 years, 6 months ago (2017-06-21 13:05:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893003/40001
3 years, 6 months ago (2017-06-21 13:21:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/25164)
3 years, 6 months ago (2017-06-21 13:30:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893003/60001
3 years, 6 months ago (2017-06-21 14:39:09 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 16:00:30 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/1168fd4ed560176987116f06f...

Powered by Google App Engine
This is Rietveld 408576698