Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2946263002: Make VideoProcessor::Init void (always returning true). (Closed)

Created:
3 years, 6 months ago by åsapersson
Modified:
3 years, 6 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make VideoProcessor::Init void (always returning true). BUG=none Review-Url: https://codereview.webrtc.org/2946263002 Cr-Commit-Position: refs/heads/master@{#18711} Committed: https://chromium.googlesource.com/external/webrtc/+/1d29c86cbf1e4cd658e44b769c914c9d35ede3ac

Patch Set 1 #

Patch Set 2 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 4 chunks +3 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 6 chunks +9 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
åsapersson
3 years, 6 months ago (2017-06-21 14:39:17 UTC) #5
brandtr
lgtm
3 years, 6 months ago (2017-06-22 07:17:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946263002/60001
3 years, 6 months ago (2017-06-22 09:16:49 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 09:18:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/1d29c86cbf1e4cd658e44b769...

Powered by Google App Engine
This is Rietveld 408576698