Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2945753002: Roll chromium_revision b032878ebd..e438353b8b (480186:480311) (Closed)

Created:
3 years, 6 months ago by kjellander_webrtc
Modified:
3 years, 6 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision b032878ebd..e438353b8b (480186:480311) Copy Valgrind scripts from Chromium's tools/ to unblock rolling: valgrind/chrome_tests.bat valgrind/chrome_tests.py valgrind/chrome_tests.sh valgrind/common.py valgrind/gdb_helper.py valgrind/locate_valgrind.sh valgrind/memcheck_analyze.py valgrind/valgrind.gni valgrind/valgrind.sh valgrind/valgrind_test.py valgrind_test.py was stripped of its Mac and Dr Memory specific parts, which we don't use. There's still more cleanup to do, tracked in bugs.webrc.org/7849. Change log: https://chromium.googlesource.com/chromium/src/+log/b032878ebd..e438353b8b Full diff: https://chromium.googlesource.com/chromium/src/+/b032878ebd..e438353b8b Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/cfcc86588b..12890c2e86 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/da7ab41c0b..9ec24027ab * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/6a7a3c369e..50158a755d * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e351800c5..1f3a1393a1 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/541ca472e8..733d9dc5c9 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e9dc4c57fb..57e600c76c * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+log/6fb62e80ac..4bf9c03d93 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/bf99adb051..919bf71aa0 DEPS diff: https://chromium.googlesource.com/chromium/src/+/b032878ebd..e438353b8b/DEPS No update to Clang. TBR=ehmaldonado@webrtc.org BUG=webrtc:7849 NOTRY=True Review-Url: https://codereview.webrtc.org/2945753002 Cr-Commit-Position: refs/heads/master@{#18650} Committed: https://chromium.googlesource.com/external/webrtc/+/0393de4b561bd751360751f5ca1b5d8d9321a3e7

Patch Set 1 #

Patch Set 2 : Updated .gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2726 lines, -21 lines) Patch
M DEPS View 6 chunks +9 lines, -9 lines 0 comments Download
A tools_webrtc/valgrind/chrome_tests.bat View 1 chunk +53 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/chrome_tests.py View 1 chunk +869 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/chrome_tests.sh View 1 chunk +94 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/common.py View 1 chunk +256 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/gdb_helper.py View 1 chunk +91 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/locate_valgrind.sh View 1 chunk +73 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/memcheck_analyze.py View 1 chunk +644 lines, -0 lines 0 comments Download
M tools_webrtc/valgrind/valgrind.gni View 1 1 chunk +0 lines, -11 lines 0 comments Download
A tools_webrtc/valgrind/valgrind.sh View 1 chunk +110 lines, -0 lines 0 comments Download
M tools_webrtc/valgrind/valgrind-webrtc.gni View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tools_webrtc/valgrind/valgrind_test.py View 1 chunk +517 lines, -0 lines 0 comments Download
M tools_webrtc/valgrind/webrtc_tests.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (9 generated)
kjellander_webrtc
Only running the failed trybot from the autoroller CL https://codereview.webrtc.org/2944783002/ since I manually copied a ...
3 years, 6 months ago (2017-06-18 20:12:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2945753002/20001
3 years, 6 months ago (2017-06-18 20:19:26 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-18 20:21:27 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0393de4b561bd751360751f5c...

Powered by Google App Engine
This is Rietveld 408576698