Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2945723002: Fixing incorrect use of erase/remove idiom. (Closed)

Created:
3 years, 6 months ago by Taylor Brandstetter
Modified:
3 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing incorrect use of erase/remove idiom. In this case it wasn't an issue, because only one result would be found by remove_if, but might as well fix it just in case. BUG=None TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2945723002 Cr-Commit-Position: refs/heads/master@{#18641} Committed: https://chromium.googlesource.com/external/webrtc/+/19b3a554e8dc9e484906060576a5151e794c34cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M webrtc/pc/statscollector.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
3 years, 6 months ago (2017-06-17 02:53:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2945723002/1
3 years, 6 months ago (2017-06-17 02:53:55 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 03:19:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/19b3a554e8dc9e48490606057...

Powered by Google App Engine
This is Rietveld 408576698