Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2944753002: Fix AVFoundation framework import (Closed)

Created:
3 years, 6 months ago by hansemannn
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix AVFoundation framework import When building the WebRTC project for iOS, the build will fail on Xcode 9 because of a missing framework-header (AVFoundation). This pull-request will add the missing "#import <AVFoundation/AVFoundation.h>" line to the "RTCCameraVideoCapturer" class. BUG=webrtc:7846 Review-Url: https://codereview.webrtc.org/2944753002 Cr-Commit-Position: refs/heads/master@{#18698} Committed: https://chromium.googlesource.com/external/webrtc/+/1b2469b8787678cd7220b4f34bd3193fe2477363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kjellander_webrtc
3 years, 6 months ago (2017-06-19 06:29:24 UTC) #5
magjed_webrtc
lgtm
3 years, 6 months ago (2017-06-19 12:54:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2944753002/1
3 years, 6 months ago (2017-06-21 10:08:45 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 10:44:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1b2469b8787678cd7220b4f34...

Powered by Google App Engine
This is Rietveld 408576698