Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2944033003: Change decoder thread to use new thread function type (Closed)

Created:
3 years, 6 months ago by tommi
Modified:
3 years, 6 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor updates to VideoReceiveStream: * Change decoder thread to use new thread function type. * Reduce the time of when video_receiver_ receives callbacks on the process thread to match with Start/Stop of the decoder. * Not triggering shutdown unless the thread is running. BUG=webrtc:7361 Review-Url: https://codereview.webrtc.org/2944033003 Cr-Commit-Position: refs/heads/master@{#18675} Committed: https://chromium.googlesource.com/external/webrtc/+/c8ece43a6266d8de11b678729e71fa2a16b924d5

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M webrtc/video/video_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 7 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
tommi
3 years, 6 months ago (2017-06-19 18:38:17 UTC) #7
tommi
git cl format
3 years, 6 months ago (2017-06-19 18:38:44 UTC) #8
stefan-webrtc
LGTM, but please let philipel take a look too.
3 years, 6 months ago (2017-06-20 07:04:37 UTC) #14
philipel
lgtm
3 years, 6 months ago (2017-06-20 09:02:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2944033003/20001
3 years, 6 months ago (2017-06-20 09:42:18 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 09:44:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c8ece43a6266d8de11b678729...

Powered by Google App Engine
This is Rietveld 408576698