Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2943343002: Merge to 60: Avoid toggling default receive streams in WebRtcVideoChannel2. (Closed)

Created:
3 years, 6 months ago by brandtr
Modified:
3 years, 6 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tommi, mflodman
Target Ref:
refs/branch-heads/60
Project:
webrtc
Visibility:
Public.

Description

Merge to 60: Avoid toggling default receive streams in WebRtcVideoChannel2. This CL removes |default_recv_ssrc_| from DefaultUnsignalledSsrcHandler and replaces it with calls to a new member function WebRtcVideoChannel2::GetDefaultReceiveStreamSsrc. The latter checks the |default_stream_| member on the WebRtcVideoChannel2::WebRtcVideoReceiveStreams to know which stream is the current default stream. This change removes duplicate state and fixes an issue where incoming unsignaled SSRCs would compete for being the default receive stream. BUG=webrtc:7725, chromium:731679 TBR=sprang@webrtc.org, deadbeef@webrtc.org NOTRY=True NOPRESUBMIT=True Review-Url (original): https://codereview.webrtc.org/2906893002 Cr-Commit-Position (original): refs/heads/master@{#18314} Review-Url: https://codereview.webrtc.org/2943343002 Cr-Commit-Position: refs/branch-heads/60@{#3} Cr-Branched-From: c61bf947b4ac31f3500858ffcae6fee39d799930-refs/heads/master@{#18252} Committed: https://chromium.googlesource.com/external/webrtc/+/9692b879044aadbee4430d2ebf69c3e61d34f40a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -14 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 5 chunks +27 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2943343002/1
3 years, 6 months ago (2017-06-20 07:26:24 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 07:26:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9692b879044aadbee4430d2eb...

Powered by Google App Engine
This is Rietveld 408576698