Fix uploading of available send bitrate statistics.

Fix uploading of available send bitrate statistics.

BUG=webrtc:5079
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2943073002 .
Cr-Commit-Position: refs/heads/master@{#18664}
Committed: https://chromium.googlesource.com/external/webrtc/+/42308f615c54be1eab64dedfdcc72787954acda7

[alexnarest1, 2017-06-16 09:06:13]

Description was changed from

==========
Fix uploading of available send bitrate statistics.

BUG=None
==========

to

==========
Fix uploading of available send bitrate statistics.

BUG=None
==========

[alexnarest1, 2017-06-16 09:06:14]

alexnarest@google.com changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-06-16 10:33:03]

Is there a test we can modify to ensure this works as expected?

[stefan-webrtc, 2017-06-16 13:47:30]

BTW, feel free to use:
BUG=webrtc:5079

[alexnarest1, 2017-06-16 14:03:08]

Description was changed from

==========
Fix uploading of available send bitrate statistics.

BUG=None
==========

to

==========
Fix uploading of available send bitrate statistics.

BUG=webrtc:5079
==========

[alexnarest1, 2017-06-19 12:51:27]

On 2017/06/16 10:33:03, stefan-webrtc wrote:
> Is there a test we can modify to ensure this works as expected?

Added a test for audio BWE stats reporting. The test fails with the code without
the fix.

[stefan-webrtc, 2017-06-19 13:07:05]

Thanks for the test. In general looks good, just two comments.

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
File webrtc/pc/statscollector_unittest.cc (right):

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
webrtc/pc/statscollector_unittest.cc:919: }));
Run 'git cl format' to get nice formatting of this code.

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
webrtc/pc/statscollector_unittest.cc:921: MockVoiceMediaChannel* media_channel =
new MockVoiceMediaChannel();
I believe this is leaking. Either use "std::unique_ptr<MockVoiceMediaChannel>
media_channel" or "MockVoiceMediaChannel media_channel".

[alexnarest1, 2017-06-19 13:55:21]

alexnarest@google.com changed reviewers:
+ alexnarest@google.com

[alexnarest1, 2017-06-19 13:55:22]

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
File webrtc/pc/statscollector_unittest.cc (right):

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
webrtc/pc/statscollector_unittest.cc:919: }));
On 2017/06/19 13:07:05, stefan-webrtc wrote:
> Run 'git cl format' to get nice formatting of this code.

Done.

https://codereview.webrtc.org/2943073002/diff/20001/webrtc/pc/statscollector_...
webrtc/pc/statscollector_unittest.cc:921: MockVoiceMediaChannel* media_channel =
new MockVoiceMediaChannel();
On 2017/06/19 13:07:05, stefan-webrtc wrote:
> I believe this is leaking. Either use "std::unique_ptr<MockVoiceMediaChannel>
> media_channel" or "MockVoiceMediaChannel media_channel".

It will not leak because BaseChannel will release it
https://cs.corp.google.com/piper///depot/google3/third_party/webrtc/files/sta...

[stefan-webrtc, 2017-06-19 14:42:35]

lgtm

[alexnarest, 2017-06-19 14:51:41]

The CQ bit was checked by alexnarest@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 14:51:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-19 15:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 15:21:16]

Dry run: This issue passed the CQ dry run.

[alexnarest, 2017-06-19 15:58:21]

Description was changed from

==========
Fix uploading of available send bitrate statistics.

BUG=webrtc:5079
==========

to

==========
Fix uploading of available send bitrate statistics.

BUG=webrtc:5079
R=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2943073002 .
Cr-Commit-Position: refs/heads/master@{#18664}
Committed:
https://chromium.googlesource.com/external/webrtc/+/42308f615c54be1eab64dedfd...
==========

[alexnarest, 2017-06-19 15:58:23]

Committed patchset #3 (id:40001) manually as
42308f615c54be1eab64dedfdcc72787954acda7 (presubmit successful).