Opus implementation of the AudioDecoderFactoryTemplate API

Opus implementation of the AudioDecoderFactoryTemplate API

BUG=webrtc:7837
Review-Url: https://codereview.webrtc.org/2942733003
Cr-Commit-Position: refs/heads/master@{#18646}
Committed: https://chromium.googlesource.com/external/webrtc/+/d053fe4ab36a77db866fb813fec825a116590704

[kwiberg-webrtc, 2017-06-15 12:42:55]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 12:43:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-06-15 12:56:53]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org, solenberg@webrtc.org

[commit-bot: I haz the power, 2017-06-15 13:19:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 13:19:46]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-06-16 09:30:21]

Description was changed from

==========
Opus implementation of the AudioDecoderFactoryTemplate API

BUG=webrtc:5805
==========

to

==========
Opus implementation of the AudioDecoderFactoryTemplate API

BUG=webrtc:7837
==========

[ossu, 2017-06-16 12:38:18]

lgtm

[the sun, 2017-06-16 12:49:14]

lgtm

https://codereview.webrtc.org/2942733003/diff/1/webrtc/api/audio_codecs/opus/...
File webrtc/api/audio_codecs/opus/audio_decoder_opus.h (right):

https://codereview.webrtc.org/2942733003/diff/1/webrtc/api/audio_codecs/opus/...
webrtc/api/audio_codecs/opus/audio_decoder_opus.h:33: static
std::unique_ptr<AudioDecoder> MakeAudioDecoder(Config config);
const &?

[kwiberg-webrtc, 2017-06-18 00:42:39]

https://codereview.webrtc.org/2942733003/diff/1/webrtc/api/audio_codecs/opus/...
File webrtc/api/audio_codecs/opus/audio_decoder_opus.h (right):

https://codereview.webrtc.org/2942733003/diff/1/webrtc/api/audio_codecs/opus/...
webrtc/api/audio_codecs/opus/audio_decoder_opus.h:33: static
std::unique_ptr<AudioDecoder> MakeAudioDecoder(Config config);
On 2017/06/16 12:49:14, the sun wrote:
> const &?

That struct contains only an int, so pass-by-value seems appropriate.

[kwiberg-webrtc, 2017-06-18 00:43:17]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 00:43:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-18 01:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-18 01:10:12]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-06-18 01:38:47]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-06-18 01:38:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-18 01:40:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497749927043680, "parent_rev":
"fe1aa82c63380c2f79c60cbe1f50ed13144a093f", "commit_rev":
"d053fe4ab36a77db866fb813fec825a116590704"}

[commit-bot: I haz the power, 2017-06-18 01:40:58]

Description was changed from

==========
Opus implementation of the AudioDecoderFactoryTemplate API

BUG=webrtc:7837
==========

to

==========
Opus implementation of the AudioDecoderFactoryTemplate API

BUG=webrtc:7837

Review-Url: https://codereview.webrtc.org/2942733003
Cr-Commit-Position: refs/heads/master@{#18646}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d053fe4ab36a77db866fb813f...
==========

[commit-bot: I haz the power, 2017-06-18 01:40:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d053fe4ab36a77db866fb813f...

[charujain, 2017-06-18 09:37:02]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2944763002/ by charujain@webrtc.org.

The reason for reverting is: breaking downstream projects.