Add has_value() and value() methods to rtc::Optional.

Add has_value() and value() methods to rtc::Optional.

These methods have the same behavior as their counterparts in std::optional, except that rtc::Optional::value() requires that the value exists whereas std::optional::value() throws an exception.

BUG=webrtc:7843
Review-Url: https://codereview.webrtc.org/2942203002
Cr-Commit-Position: refs/heads/master@{#18631}
Committed: https://chromium.googlesource.com/external/webrtc/+/f79dbadc09255c91b9163449dfa8898a8be29744

[terelius, 2017-06-16 12:46:09]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 12:46:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-06-16 12:46:35]

terelius@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-06-16 12:53:41]

lgtm, but see comment

https://codereview.webrtc.org/2942203002/diff/1/webrtc/base/optional.h
File webrtc/base/optional.h (right):

https://codereview.webrtc.org/2942203002/diff/1/webrtc/base/optional.h#newcod...
webrtc/base/optional.h:247: }
The preceding functions all have const first, non-const after. Do the same for
value()?

[terelius, 2017-06-16 12:59:18]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 12:59:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-06-16 12:59:58]

https://codereview.webrtc.org/2942203002/diff/1/webrtc/base/optional.h
File webrtc/base/optional.h (right):

https://codereview.webrtc.org/2942203002/diff/1/webrtc/base/optional.h#newcod...
webrtc/base/optional.h:247: }
On 2017/06/16 12:53:41, kwiberg-webrtc wrote:
> The preceding functions all have const first, non-const after. Do the same for
> value()?

Done.

[commit-bot: I haz the power, 2017-06-16 13:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 13:43:36]

Dry run: This issue passed the CQ dry run.

[terelius, 2017-06-16 13:45:53]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2017-06-16 13:45:54]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2942203002/#ps20001 (title:
"Reorder declarations")

[commit-bot: I haz the power, 2017-06-16 13:46:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-16 13:48:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497620753815160,
"parent_rev": "0ef8fb91b4930783f0f32cbd3a68e5f98b6ebdd4", "commit_rev":
"f79dbadc09255c91b9163449dfa8898a8be29744"}

[commit-bot: I haz the power, 2017-06-16 13:48:19]

Description was changed from

==========
Add has_value() and value() methods to rtc::Optional.

These methods have the same behavior as their counterparts in std::optional,
except that rtc::Optional::value() requires that the value exists whereas
std::optional::value() throws an exception.

BUG=webrtc:7843
==========

to

==========
Add has_value() and value() methods to rtc::Optional.

These methods have the same behavior as their counterparts in std::optional,
except that rtc::Optional::value() requires that the value exists whereas
std::optional::value() throws an exception.

BUG=webrtc:7843

Review-Url: https://codereview.webrtc.org/2942203002
Cr-Commit-Position: refs/heads/master@{#18631}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f79dbadc09255c91b9163449d...
==========

[commit-bot: I haz the power, 2017-06-16 13:48:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f79dbadc09255c91b9163449d...