Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2941453003: Declaring rtc_base_approved dep on webrtc_common (Closed)

Created:
3 years, 6 months ago by mbonadei
Modified:
3 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), peah-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Declaring rtc_base_approved dep on webrtc_common BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2941453003 Cr-Commit-Position: refs/heads/master@{#18562} Committed: https://chromium.googlesource.com/external/webrtc/+/fdfeb8361ea10d9cf24d3f833aef8a6ea80415a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mbonadei
3 years, 6 months ago (2017-06-13 11:39:46 UTC) #2
kjellander_webrtc
lgtm
3 years, 6 months ago (2017-06-13 11:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2941453003/1
3 years, 6 months ago (2017-06-13 11:51:16 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 11:53:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fdfeb8361ea10d9cf24d3f833...

Powered by Google App Engine
This is Rietveld 408576698