Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2941023002: Use the same QP max for tests as in production (Closed)

Created:
3 years, 6 months ago by sprang_webrtc
Modified:
3 years, 6 months ago
Reviewers:
mflodman1, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use the same QP max for tests as in production BUG=webrtc:7664 Review-Url: https://codereview.webrtc.org/2941023002 Cr-Commit-Position: refs/heads/master@{#18611} Committed: https://chromium.googlesource.com/external/webrtc/+/67561a6411f308d122c5707e9a5ec574ad59cd3a

Patch Set 1 #

Patch Set 2 : deps #

Total comments: 2

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M webrtc/media/engine/webrtcvideoengine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sprang_webrtc
3 years, 6 months ago (2017-06-15 09:32:18 UTC) #2
mflodman1
One comment, then LGTM. https://codereview.webrtc.org/2941023002/diff/20001/webrtc/media/engine/webrtcvideoengine.cc File webrtc/media/engine/webrtcvideoengine.cc (right): https://codereview.webrtc.org/2941023002/diff/20001/webrtc/media/engine/webrtcvideoengine.cc#newcode365 webrtc/media/engine/webrtcvideoengine.cc:365: constexpr int WebRtcVideoChannel::kDefaultQpMax; Can skip ...
3 years, 6 months ago (2017-06-15 12:41:16 UTC) #4
sprang_webrtc
https://codereview.webrtc.org/2941023002/diff/20001/webrtc/media/engine/webrtcvideoengine.cc File webrtc/media/engine/webrtcvideoengine.cc (right): https://codereview.webrtc.org/2941023002/diff/20001/webrtc/media/engine/webrtcvideoengine.cc#newcode365 webrtc/media/engine/webrtcvideoengine.cc:365: constexpr int WebRtcVideoChannel::kDefaultQpMax; On 2017/06/15 12:41:16, mflodman1 wrote: > ...
3 years, 6 months ago (2017-06-15 12:45:12 UTC) #5
mflodman
LGTM
3 years, 6 months ago (2017-06-15 12:46:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2941023002/40001
3 years, 6 months ago (2017-06-15 12:47:31 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 13:34:48 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/67561a6411f308d122c5707e9...

Powered by Google App Engine
This is Rietveld 408576698