Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2940833002: G722 implementation of the AudioDecoderFactoryTemplate API (Closed)

Created:
3 years, 6 months ago by kwiberg-webrtc
Modified:
3 years, 6 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

G722 implementation of the AudioDecoderFactoryTemplate API Now the templated AudioDecoderFactory can create G722 decoders! BUG=webrtc:7839 Review-Url: https://codereview.webrtc.org/2940833002 Cr-Commit-Position: refs/heads/master@{#18643} Committed: https://chromium.googlesource.com/external/webrtc/+/b1ed7f09c0ed3dfdac88d4b5d4c28629c373ac5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -35 lines) Patch
A + webrtc/api/audio_codecs/g722/BUILD.gn View 1 chunk +11 lines, -15 lines 0 comments Download
A webrtc/api/audio_codecs/g722/audio_decoder_g722.h View 1 chunk +36 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/g722/audio_decoder_g722.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
kwiberg-webrtc
3 years, 6 months ago (2017-06-15 12:55:32 UTC) #11
ossu
lgtm
3 years, 6 months ago (2017-06-16 12:38:13 UTC) #14
the sun
lgtm
3 years, 6 months ago (2017-06-16 12:46:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2940833002/40001
3 years, 6 months ago (2017-06-17 22:57:15 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-18 00:30:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b1ed7f09c0ed3dfdac88d4b5d...

Powered by Google App Engine
This is Rietveld 408576698