Use RaceChecker instead of ThreadChecker in a few places.

Use RaceChecker instead of ThreadChecker in a few places.

There are some functions in packet_router.cc and modules/congestion_controller that could be used by different threads, but they're protected using rtc::ThreadChecker which doesn't allow them to be called by more than one thread even if the calls are synchronised. This CL replaces those with rtc::RaceChecker, which allows serialized access of the functions from multiple threads.

BUG=webrtc:7826
Review-Url: https://codereview.webrtc.org/2940133003
Cr-Commit-Position: refs/heads/master@{#18628}
Committed: https://chromium.googlesource.com/external/webrtc/+/bf5a2fc11bc53a19735dad278990fad0d21e5ec5

[erikvarga1, 2017-06-15 20:58:42]

Description was changed from

==========
Use RaceChecker instead of ThreadChecker in a few places.

There are some functions in packet_router.cc and modules/congestion_controller
that could be used by different threads, but they're protected using
rtc::ThreadChecker which doesn't allow them to be called by more than one thread
even if the calls are synchronised. This CL replaces those with
rtc::RaceChecker, which allows serialized access of the functions from multiple
threads.

BUG=7826
==========

to

==========
Use RaceChecker instead of ThreadChecker in a few places.

There are some functions in packet_router.cc and modules/congestion_controller
that could be used by different threads, but they're protected using
rtc::ThreadChecker which doesn't allow them to be called by more than one thread
even if the calls are synchronised. This CL replaces those with
rtc::RaceChecker, which allows serialized access of the functions from multiple
threads.

BUG=webrtc:7826
==========

[erikvarga1, 2017-06-15 20:58:42]

erikvarga@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2017-06-16 08:23:31]

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/delay_based_bwe.h (right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/delay_based_bwe.h:73: rtc::RaceChecker
race_checker_;
one of the reason for sync checkers is documentation: Where those functions
assumed to be called from.
So it would be good idea to keep 'network' in the variable name.
(network_race_ /check_network_race_ ?)

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
File
webrtc/modules/congestion_controller/include/send_side_congestion_controller.h
(right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/include/send_side_congestion_controller.h:158:
rtc::RaceChecker race_checker_;
keep the word 'worker' even if you are dropping word 'thread'

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/pacing/packet_...
File webrtc/modules/pacing/packet_router.h (right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/pacing/packet_...
webrtc/modules/pacing/packet_router.h:87: rtc::RaceChecker race_checker_;
ditto

[erikvarga1, 2017-06-16 08:43:25]

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/delay_based_bwe.h (right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/delay_based_bwe.h:73: rtc::RaceChecker
race_checker_;
On 2017/06/16 08:23:31, danilchap wrote:
> one of the reason for sync checkers is documentation: Where those functions
> assumed to be called from.
> So it would be good idea to keep 'network' in the variable name.
> (network_race_ /check_network_race_ ?)

Done.

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
File
webrtc/modules/congestion_controller/include/send_side_congestion_controller.h
(right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/include/send_side_congestion_controller.h:158:
rtc::RaceChecker race_checker_;
On 2017/06/16 08:23:31, danilchap wrote:
> keep the word 'worker' even if you are dropping word 'thread'

Done.

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/pacing/packet_...
File webrtc/modules/pacing/packet_router.h (right):

https://codereview.webrtc.org/2940133003/diff/1/webrtc/modules/pacing/packet_...
webrtc/modules/pacing/packet_router.h:87: rtc::RaceChecker race_checker_;
On 2017/06/16 08:23:31, danilchap wrote:
> ditto

Done.

[danilchap, 2017-06-16 08:52:21]

lgtm

[erikvarga1, 2017-06-16 09:09:38]

erikvarga@webrtc.org changed reviewers:
+ stefan@webrtc.org

[erikvarga1, 2017-06-16 09:12:16]

Stefan, could you also take a look at this CL? Thanks.

[stefan-webrtc, 2017-06-16 11:06:28]

lgtm

[erikvarga1, 2017-06-16 11:16:50]

The CQ bit was checked by erikvarga@webrtc.org

[commit-bot: I haz the power, 2017-06-16 11:16:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-16 12:02:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497611810210750,
"parent_rev": "bd09ebc71eb49e613e21da289be99afc68fcb071", "commit_rev":
"bf5a2fc11bc53a19735dad278990fad0d21e5ec5"}

[commit-bot: I haz the power, 2017-06-16 12:02:10]

Description was changed from

==========
Use RaceChecker instead of ThreadChecker in a few places.

There are some functions in packet_router.cc and modules/congestion_controller
that could be used by different threads, but they're protected using
rtc::ThreadChecker which doesn't allow them to be called by more than one thread
even if the calls are synchronised. This CL replaces those with
rtc::RaceChecker, which allows serialized access of the functions from multiple
threads.

BUG=webrtc:7826
==========

to

==========
Use RaceChecker instead of ThreadChecker in a few places.

There are some functions in packet_router.cc and modules/congestion_controller
that could be used by different threads, but they're protected using
rtc::ThreadChecker which doesn't allow them to be called by more than one thread
even if the calls are synchronised. This CL replaces those with
rtc::RaceChecker, which allows serialized access of the functions from multiple
threads.

BUG=webrtc:7826

Review-Url: https://codereview.webrtc.org/2940133003
Cr-Commit-Position: refs/heads/master@{#18628}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bf5a2fc11bc53a19735dad278...
==========

[commit-bot: I haz the power, 2017-06-16 12:02:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/bf5a2fc11bc53a19735dad278...