Use information about blacklisted devices in video_quality_loopback_test

Use information about blacklisted devices in video_quality_loopback_test

BUG=webrtc:7724
NOTRY=True

Review-Url: https://codereview.webrtc.org/2937123002
Cr-Commit-Position: refs/heads/master@{#18654}
Committed: https://chromium.googlesource.com/external/webrtc/+/bed7a6b3b6c63bd2f9a3495b18184c9f438b7cf6

[oprypin_webrtc, 2017-06-16 08:34:32]

Patchset #1 (id:1) has been deleted

[oprypin_webrtc, 2017-06-16 08:34:40]

Patchset #1 (id:20001) has been deleted

[oprypin_webrtc, 2017-06-16 08:36:02]

Description was changed from

==========
Use information about blacklisted devices in video_quality_loopback_test

BUG=webrtc:7724
==========

to

==========
Use information about blacklisted devices in video_quality_loopback_test

BUG=webrtc:7724
NOTRY=True
==========

[oprypin_webrtc, 2017-06-16 08:36:45]

oprypin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-06-16 13:19:50]

lgtm with comment addressed

https://codereview.webrtc.org/2937123002/diff/40001/webrtc/examples/androidte...
File webrtc/examples/androidtests/video_quality_loopback_test.py (right):

https://codereview.webrtc.org/2937123002/diff/40001/webrtc/examples/androidte...
webrtc/examples/androidtests/video_quality_loopback_test.py:120:
logging.warning('Cannot read %r', BAD_DEVICES_JSON)
How about only printing this if we're on a bot?

if os.environ.get('CHROME_HEADLESS'):
  logging.warning('Cannot read %r', BAD_DEVICES_JSON)

[oprypin_webrtc, 2017-06-19 08:14:15]

https://codereview.webrtc.org/2937123002/diff/40001/webrtc/examples/androidte...
File webrtc/examples/androidtests/video_quality_loopback_test.py (right):

https://codereview.webrtc.org/2937123002/diff/40001/webrtc/examples/androidte...
webrtc/examples/androidtests/video_quality_loopback_test.py:120:
logging.warning('Cannot read %r', BAD_DEVICES_JSON)
On 2017/06/16 13:19:49, kjellander_webrtc wrote:
> How about only printing this if we're on a bot?
> 
> if os.environ.get('CHROME_HEADLESS'):
>   logging.warning('Cannot read %r', BAD_DEVICES_JSON)

Done. Thanks.

[oprypin_webrtc, 2017-06-19 08:14:32]

The CQ bit was checked by oprypin@webrtc.org

[oprypin_webrtc, 2017-06-19 08:14:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2937123002/#ps60001 (title:
"Warning only on chrome infra")

[commit-bot: I haz the power, 2017-06-19 08:14:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-19 08:16:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497860072914430,
"parent_rev": "429d614b833aea3ffe28acdf3953bd1c609864d3", "commit_rev":
"bed7a6b3b6c63bd2f9a3495b18184c9f438b7cf6"}

[commit-bot: I haz the power, 2017-06-19 08:16:50]

Description was changed from

==========
Use information about blacklisted devices in video_quality_loopback_test

BUG=webrtc:7724
NOTRY=True
==========

to

==========
Use information about blacklisted devices in video_quality_loopback_test

BUG=webrtc:7724
NOTRY=True

Review-Url: https://codereview.webrtc.org/2937123002
Cr-Commit-Position: refs/heads/master@{#18654}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bed7a6b3b6c63bd2f9a3495b1...
==========

[commit-bot: I haz the power, 2017-06-19 08:16:51]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/bed7a6b3b6c63bd2f9a3495b1...