Support H.264 high profile encoding on Exynos devices.

Support H.264 high profile encoding on Exynos devices.

Guarded by field trial - similar to high profile encoder.
If high profile is requested, but device do not support it
then fallback to baseline profile.

BUG=b/34816463

Review-Url: https://codereview.webrtc.org/2936313002
Cr-Commit-Position: refs/heads/master@{#18619}
Committed: https://chromium.googlesource.com/external/webrtc/+/3fc2350ef95be350ac6d4156270930c49fb58361

[AlexG, 2017-06-14 21:40:26]

glaznev@webrtc.org changed reviewers:
+ alexlau@webrtc.org, brandtr@webrtc.org

[AlexG, 2017-06-14 21:40:28]

PTAL

[alexlau, 2017-06-14 23:09:43]

lgtm

[brandtr, 2017-06-15 09:04:05]

brandtr@webrtc.org changed reviewers:
+ magjed@webrtc.org

[brandtr, 2017-06-15 09:04:06]

lgtm, but please let +magjed have a look too, as he is more familiar with the
profiles than me.

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:99: // Should be
in sync with webrtc::H264::Profile
nit: end comment with period.

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:453:
Logging.d(TAG, "High profile H.264 encoder supported");
nit: period.

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/src/jni/an...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/src/jni/an...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:543: << " kbps. Fps: " <<
fps << ". Profile: " << profile_;
nit: add << ".";

[magjed_webrtc, 2017-06-15 19:26:07]

Description was changed from

==========
Support H.264 high profile encoding on Exynos devices.

Guarded by field trial - similar to high profile encoder.
If high profile is requested, but device do not support it
then fallback to baseline profile.

BUG=b/34816463
==========

to

==========
Support H.264 high profile encoding on Exynos devices.

Guarded by field trial - similar to high profile encoder.
If high profile is requested, but device do not support it
then fallback to baseline profile.

BUG=b/34816463
==========

[magjed_webrtc, 2017-06-15 19:29:07]

lgtm

Please note that we are working on making the Android HW codecs injectable
through the PeerconnectionFactory interface similar to C++, so in the future we
will have to update 
webrtc/sdk/android/api/org/webrtc/VideoEncoder.java rather than these files, and
the jni code will be generic for any codec.

[AlexG, 2017-06-15 23:01:12]

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:99: // Should be
in sync with webrtc::H264::Profile
On 2017/06/15 09:04:05, brandtr wrote:
> nit: end comment with period.

Done.

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:453:
Logging.d(TAG, "High profile H.264 encoder supported");
On 2017/06/15 09:04:05, brandtr wrote:
> nit: period.

Done.

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/src/jni/an...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2936313002/diff/1/webrtc/sdk/android/src/jni/an...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:543: << " kbps. Fps: " <<
fps << ". Profile: " << profile_;
On 2017/06/15 09:04:06, brandtr wrote:
> nit: add << ".";

Done.

[AlexG, 2017-06-15 23:02:10]

The CQ bit was checked by glaznev@webrtc.org

[AlexG, 2017-06-15 23:02:11]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
brandtr@webrtc.org, alexlau@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2936313002/#ps20001 (title:
"Address comments")

[commit-bot: I haz the power, 2017-06-15 23:02:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-15 23:24:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497567730966660,
"parent_rev": "24d00ddd8c4d7b7dcc464d6123eb2a5d07f6f88b", "commit_rev":
"3fc2350ef95be350ac6d4156270930c49fb58361"}

[commit-bot: I haz the power, 2017-06-15 23:24:42]

Description was changed from

==========
Support H.264 high profile encoding on Exynos devices.

Guarded by field trial - similar to high profile encoder.
If high profile is requested, but device do not support it
then fallback to baseline profile.

BUG=b/34816463
==========

to

==========
Support H.264 high profile encoding on Exynos devices.

Guarded by field trial - similar to high profile encoder.
If high profile is requested, but device do not support it
then fallback to baseline profile.

BUG=b/34816463

Review-Url: https://codereview.webrtc.org/2936313002
Cr-Commit-Position: refs/heads/master@{#18619}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3fc2350ef95be350ac6d41562...
==========

[commit-bot: I haz the power, 2017-06-15 23:24:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3fc2350ef95be350ac6d41562...