Delete class DirectoryIterator and FileRotatingStream read support.
This is an exploratory cl, to find out what breaks when these features
are removed.
BUG=webrtc:7812, webrtc:6424
PTAL. I think both the android and the objc apis need a method to read ...
3 years, 7 months ago
(2017-06-14 09:08:27 UTC)
#2
PTAL. I think both the android and the objc apis need a method to read the log
files, so that needs to be rewritten. If we really want to do it in C++ and
avoid code duplication, we could add something minimal based on the
ReadLogDirectory function I have in the test.
nisse-webrtc
On 2017/06/14 09:08:27, nisse-webrtc wrote: > PTAL. I think both the android and the objc ...
3 years, 7 months ago
(2017-06-14 11:46:04 UTC)
#3
On 2017/06/14 09:08:27, nisse-webrtc wrote:
> PTAL. I think both the android and the objc apis need a method to read the log
> files, so that needs to be rewritten. If we really want to do it in C++ and
> avoid code duplication, we could add something minimal based on the
> ReadLogDirectory function I have in the test.
And the linux_internal failures look as could be expected.
nisse-webrtc
On 2017/06/14 11:46:04, nisse-webrtc wrote: > On 2017/06/14 09:08:27, nisse-webrtc wrote: > > PTAL. I ...
3 years, 3 months ago
(2017-09-29 12:58:59 UTC)
#4
On 2017/06/14 11:46:04, nisse-webrtc wrote:
> On 2017/06/14 09:08:27, nisse-webrtc wrote:
> > PTAL. I think both the android and the objc apis need a method to read the
log
> > files, so that needs to be rewritten. If we really want to do it in C++ and
> > avoid code duplication, we could add something minimal based on the
> > ReadLogDirectory function I have in the test.
>
> And the linux_internal failures look as could be expected.
Moved to gerrit, cl https://webrtc-review.googlesource.com/c/src/+/4821
Issue 2935933007: Delete class DirectoryIterator and FileRotatingStream read support.
(Closed)
Created 3 years, 7 months ago by nisse-webrtc
Modified 3 years, 3 months ago
Reviewers: kthelgason
Base URL:
Comments: 0