Removing backward compatible header

Removing backward compatible header

I have updated downstream projects and now it is safe to remove this
header.

BUG=webrtc:7647
NOTRY=True

Review-Url: https://codereview.webrtc.org/2935933002
Cr-Commit-Position: refs/heads/master@{#18561}
Committed: https://chromium.googlesource.com/external/webrtc/+/733971225697236be331df2557ee48222f8e4a35

[mbonadei, 2017-06-13 08:22:20]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org, magjed@webrtc.org

[magjed_webrtc, 2017-06-13 08:35:01]

https://codereview.webrtc.org/2935933002/diff/20001/webrtc/common_video/inclu...
File webrtc/common_video/include/corevideo_frame_buffer.h (right):

https://codereview.webrtc.org/2935933002/diff/20001/webrtc/common_video/inclu...
webrtc/common_video/include/corevideo_frame_buffer.h:11: // TODO(magjed): Remove
this file once external clients are updated.
I think it should be possible to remove this file now, can you try? I would like
to see the internal bot go green before landing this CL.

[mbonadei, 2017-06-13 08:49:25]

Ok, trybots are running.

https://codereview.webrtc.org/2935933002/diff/20001/webrtc/common_video/inclu...
File webrtc/common_video/include/corevideo_frame_buffer.h (right):

https://codereview.webrtc.org/2935933002/diff/20001/webrtc/common_video/inclu...
webrtc/common_video/include/corevideo_frame_buffer.h:11: // TODO(magjed): Remove
this file once external clients are updated.
On 2017/06/13 08:35:01, magjed_webrtc wrote:
> I think it should be possible to remove this file now, can you try? I would
like
> to see the internal bot go green before landing this CL.

Yep, you are right. I have done a quick search and it is not used.

[kjellander_webrtc, 2017-06-13 08:50:18]

No bug to reference?

lgtm assuming all bots (including linux_internal) are happy.

[mbonadei, 2017-06-13 08:52:23]

Description was changed from

==========
Removing backward compatible header

I have updated downstream projects and now it is safe to remove this
header.

BUG=None
NOTRY=True
==========

to

==========
Removing backward compatible header

I have updated downstream projects and now it is safe to remove this
header.

BUG=webrtc:7647
NOTRY=True
==========

[mbonadei, 2017-06-13 08:53:00]

On 2017/06/13 08:50:18, kjellander_webrtc wrote:
> No bug to reference?
> 
> lgtm assuming all bots (including linux_internal) are happy.

Added webrtc:7647 which is a bug I created to track all the
headers in that folder.

This cl removes one of the untracked headers.

[magjed_webrtc, 2017-06-13 11:22:43]

lgtm

[mbonadei, 2017-06-13 11:23:19]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-06-13 11:23:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-13 11:25:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497352999388440,
"parent_rev": "a735d4ebb5552c5d7b8093bdc5e82129cda67333", "commit_rev":
"733971225697236be331df2557ee48222f8e4a35"}

[commit-bot: I haz the power, 2017-06-13 11:25:41]

Description was changed from

==========
Removing backward compatible header

I have updated downstream projects and now it is safe to remove this
header.

BUG=webrtc:7647
NOTRY=True
==========

to

==========
Removing backward compatible header

I have updated downstream projects and now it is safe to remove this
header.

BUG=webrtc:7647
NOTRY=True

Review-Url: https://codereview.webrtc.org/2935933002
Cr-Commit-Position: refs/heads/master@{#18561}
Committed:
https://chromium.googlesource.com/external/webrtc/+/733971225697236be331df255...
==========

[commit-bot: I haz the power, 2017-06-13 11:25:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/733971225697236be331df255...