Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2934483002: Delete unused method Win32Filesystem::GetAppPathname. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method Win32Filesystem::GetAppPathname. Unused since cl https://codereview.webrtc.org/2872283002. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2934483002 Cr-Commit-Position: refs/heads/master@{#18552} Committed: https://chromium.googlesource.com/external/webrtc/+/687bc3e27bbd8b6a2c399deeab08af05b5f1524f

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M webrtc/base/win32filesystem.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
nisse-webrtc
PTAL.
3 years, 6 months ago (2017-06-09 13:32:53 UTC) #2
Taylor Brandstetter
lgtm
3 years, 6 months ago (2017-06-09 21:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2934483002/1
3 years, 6 months ago (2017-06-13 07:19:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/builds/8713) mac_asan on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 6 months ago (2017-06-13 07:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2934483002/20001
3 years, 6 months ago (2017-06-13 07:45:16 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 08:06:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/687bc3e27bbd8b6a2c399deea...

Powered by Google App Engine
This is Rietveld 408576698