Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2932073002: s/WebRtcVideoChannel2/WebRtcVideoChannel and s/WebRtcVideoEngine2/WebRtcVideoEngine (Closed)

Created:
3 years, 6 months ago by eladalon
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

s/WebRtcVideoChannel2/WebRtcVideoChannel and s/WebRtcVideoEngine2/WebRtcVideoEngine WebRtcVideoChannel and and WebRtcVideoEngine seem to have been removed, and only WebRtcVideoChannel2 and WebRtcVideoEngine2 remain, which removes the need for the "2" postfix. BUG=None Review-Url: https://codereview.webrtc.org/2932073002 Cr-Commit-Position: refs/heads/master@{#18531} Committed: https://chromium.googlesource.com/external/webrtc/+/f184138a5f4738be432762a4c621ad3f2b3f665e

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -8229 lines) Patch
M webrtc/call/rtp_transport_controller_send_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/engine/internaldecoderfactory.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcmediaengine.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/media/engine/webrtcvideoengine.h View 9 chunks +23 lines, -23 lines 0 comments Download
A + webrtc/media/engine/webrtcvideoengine.cc View 1 76 chunks +129 lines, -129 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 2 2 chunks +4 lines, -514 lines 0 comments Download
D webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +0 lines, -2678 lines 0 comments Download
D webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 chunk +0 lines, -4635 lines 0 comments Download
A + webrtc/media/engine/webrtcvideoengine_unittest.cc View 163 chunks +235 lines, -235 lines 0 comments Download
M webrtc/pc/rtpreceiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/webrtcsdp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
eladalon
PTAL
3 years, 6 months ago (2017-06-09 11:10:02 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine.cc File webrtc/media/engine/webrtcvideoengine.cc (right): https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine.cc#newcode465 webrtc/media/engine/webrtcvideoengine.cc:465: // 3 Remove? https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine2.h File webrtc/media/engine/webrtcvideoengine2.h (right): https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine2.h#newcode15 webrtc/media/engine/webrtcvideoengine2.h:15: ...
3 years, 6 months ago (2017-06-09 11:17:17 UTC) #4
eladalon
https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine.cc File webrtc/media/engine/webrtcvideoengine.cc (right): https://codereview.webrtc.org/2932073002/diff/1/webrtc/media/engine/webrtcvideoengine.cc#newcode465 webrtc/media/engine/webrtcvideoengine.cc:465: // 3 On 2017/06/09 11:17:17, stefan-webrtc wrote: > Remove? ...
3 years, 6 months ago (2017-06-09 11:48:37 UTC) #5
stefan-webrtc
3 years, 6 months ago (2017-06-09 14:45:46 UTC) #6
stefan-webrtc
lgtm
3 years, 6 months ago (2017-06-09 14:45:48 UTC) #7
eladalon
Adding additional owners for the other directories - PTAL.
3 years, 6 months ago (2017-06-09 17:37:28 UTC) #9
pbos-webrtc
lgtm
3 years, 6 months ago (2017-06-09 17:50:48 UTC) #11
pbos-webrtc
On 2017/06/09 17:50:48, pbos-webrtc wrote: > lgtm (just be careful + make sure the sheriff ...
3 years, 6 months ago (2017-06-09 17:51:06 UTC) #12
pbos-webrtc
+noahric@ fyi
3 years, 6 months ago (2017-06-09 17:51:25 UTC) #14
Taylor Brandstetter
lgtm
3 years, 6 months ago (2017-06-09 18:50:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2932073002/40001
3 years, 6 months ago (2017-06-12 07:42:28 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 08:16:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f184138a5f4738be432762a4c...

Powered by Google App Engine
This is Rietveld 408576698