Split rtc_task_queue target. Add separate target for sequenced_task_checker and weak_ptr.

Split rtc_task_queue target. Add separate target for sequenced_task_checker and weak_ptr.
This is to make it possible to override the rtc_task_queue target only. 

BUG=none

Review-Url: https://codereview.webrtc.org/2931273002
Cr-Commit-Position: refs/heads/master@{#18534}
Committed: https://chromium.googlesource.com/external/webrtc/+/39a41d92dd22b8dc39f2fe3f7165e6d3e28be62e

[perkj_webrtc, 2017-06-10 21:01:01]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-10 21:01:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-10 21:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 21:03:17]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/21006)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/25285)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/25333)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/26414)

[perkj_webrtc, 2017-06-12 08:36:54]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 08:37:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 08:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 08:41:13]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18019)

[perkj_webrtc, 2017-06-12 09:06:40]

Description was changed from

==========
Add separate target for sequenced_target.

BUG=
==========

to

==========
Split rtc_task_queue target. Add separate target for sequenced_task_checker and
weak_ptr.
This is to make it possible to override the rtc_task_queue target only. 

BUG=none
==========

[perkj_webrtc, 2017-06-12 09:06:41]

perkj@webrtc.org changed reviewers:
+ kjellander@webrtc.org, mbonadei@webrtc.org

[perkj_webrtc, 2017-06-12 09:07:05]

Patchset #2 (id:20001) has been deleted

[perkj_webrtc, 2017-06-12 09:07:13]

Patchset #1 (id:1) has been deleted

[perkj_webrtc, 2017-06-12 09:07:24]

Please?

[kjellander_webrtc, 2017-06-12 10:56:38]

https://codereview.webrtc.org/2931273002/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2931273002/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:338: ":rtc_base_approved",
Please move to deps or explain why public_deps is needed?

[perkj_webrtc, 2017-06-12 11:04:03]

https://codereview.webrtc.org/2931273002/diff/40001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2931273002/diff/40001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:338: ":rtc_base_approved",
On 2017/06/12 10:56:38, kjellander_webrtc wrote:
> Please move to deps or explain why public_deps is needed?

moved to weak_ptr which is actually where its needed. Thanks.

[mbonadei, 2017-06-12 11:31:12]

It is lgtm for me. I have just added a comment for a small refactoring.

[mbonadei, 2017-06-12 11:31:51]

But let's also wait for Henrik's final review.

https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:862: rtc_source_set("rtc_task_queue_unittests") {
I am thinking if it makes sense to split also the _unittests target in:

 - rtc_task_queue_unittests
 - sequenced_task_checker_unittests
 - weak_ptr_unittests

I know it is not that important but I would prefer to keep things
as symmetric as possible.

[perkj_webrtc, 2017-06-12 11:49:14]

ptal

https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:862: rtc_source_set("rtc_task_queue_unittests") {
On 2017/06/12 11:31:50, mbonadei wrote:
> I am thinking if it makes sense to split also the _unittests target in:
> 
>  - rtc_task_queue_unittests
>  - sequenced_task_checker_unittests
>  - weak_ptr_unittests
> 
> I know it is not that important but I would prefer to keep things
> as symmetric as possible.

Yes it make sense. I did not do that since I though this was a binary. But its
just another lib. I will do that.

[perkj_webrtc, 2017-06-12 11:49:34]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 11:49:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[mbonadei, 2017-06-12 11:54:42]

On 2017/06/12 11:49:14, perkj_webrtc wrote:
> ptal
> 
> https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn
> File webrtc/base/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn#newc...
> webrtc/base/BUILD.gn:862: rtc_source_set("rtc_task_queue_unittests") {
> On 2017/06/12 11:31:50, mbonadei wrote:
> > I am thinking if it makes sense to split also the _unittests target in:
> > 
> >  - rtc_task_queue_unittests
> >  - sequenced_task_checker_unittests
> >  - weak_ptr_unittests
> > 
> > I know it is not that important but I would prefer to keep things
> > as symmetric as possible.
> 
> Yes it make sense. I did not do that since I though this was a binary. But its
> just another lib. I will do that.

Great! Thanks!

[perkj_webrtc, 2017-06-12 12:04:21]

On 2017/06/12 11:54:42, mbonadei wrote:
> On 2017/06/12 11:49:14, perkj_webrtc wrote:
> > ptal
> > 
> > https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn
> > File webrtc/base/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2931273002/diff/60001/webrtc/base/BUILD.gn#newc...
> > webrtc/base/BUILD.gn:862: rtc_source_set("rtc_task_queue_unittests") {
> > On 2017/06/12 11:31:50, mbonadei wrote:
> > > I am thinking if it makes sense to split also the _unittests target in:
> > > 
> > >  - rtc_task_queue_unittests
> > >  - sequenced_task_checker_unittests
> > >  - weak_ptr_unittests
> > > 
> > > I know it is not that important but I would prefer to keep things
> > > as symmetric as possible.
> > 
> > Yes it make sense. I did not do that since I though this was a binary. But
its
> > just another lib. I will do that.
> 
> Great! Thanks!

Done in the last patch-set if you missed that.

[kjellander_webrtc, 2017-06-12 12:06:14]

lgtm

[commit-bot: I haz the power, 2017-06-12 12:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 12:07:34]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2017-06-12 12:51:09]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2017-06-12 12:51:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2931273002/#ps80001 (title:
"Split rtc_task_queue_unittests library as well.")

[commit-bot: I haz the power, 2017-06-12 12:51:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 12:53:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497271869444080,
"parent_rev": "7123029731ef065553239788a0e3c2915b7f329e", "commit_rev":
"39a41d92dd22b8dc39f2fe3f7165e6d3e28be62e"}

[commit-bot: I haz the power, 2017-06-12 12:53:39]

Description was changed from

==========
Split rtc_task_queue target. Add separate target for sequenced_task_checker and
weak_ptr.
This is to make it possible to override the rtc_task_queue target only. 

BUG=none
==========

to

==========
Split rtc_task_queue target. Add separate target for sequenced_task_checker and
weak_ptr.
This is to make it possible to override the rtc_task_queue target only. 

BUG=none

Review-Url: https://codereview.webrtc.org/2931273002
Cr-Commit-Position: refs/heads/master@{#18534}
Committed:
https://chromium.googlesource.com/external/webrtc/+/39a41d92dd22b8dc39f2fe3f7...
==========

[commit-bot: I haz the power, 2017-06-12 12:53:42]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/39a41d92dd22b8dc39f2fe3f7...