Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2930323004: Fix for broken test BweFeedbackTest. (Closed)

Created:
3 years, 6 months ago by tschumi
Modified:
3 years, 6 months ago
Reviewers:
philipel, terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for broken test BweFeedbackTest. BUG=webrtc:7746 Review-Url: https://codereview.webrtc.org/2930323004 Cr-Commit-Position: refs/heads/master@{#18582} Committed: https://chromium.googlesource.com/external/webrtc/+/b749e5e1f591fa804fb3493aec819ff39a881fc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
tschumi
Hi, Here the fix for the broken test.
3 years, 6 months ago (2017-06-13 10:55:30 UTC) #3
philipel
lgtm
3 years, 6 months ago (2017-06-13 11:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2930323004/1
3 years, 6 months ago (2017-06-13 11:32:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18093)
3 years, 6 months ago (2017-06-13 11:35:46 UTC) #12
tschumi
@terelius, Can you take a look at this.
3 years, 6 months ago (2017-06-13 13:32:44 UTC) #14
terelius
lgtm
3 years, 6 months ago (2017-06-13 13:34:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2930323004/1
3 years, 6 months ago (2017-06-14 05:56:12 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 05:58:27 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b749e5e1f591fa804fb3493ae...

Powered by Google App Engine
This is Rietveld 408576698