Reland Refactored incoming bitrate estimator.

Reland Refactored incoming bitrate estimator.

BUG=webrtc:7746
Review-Url: https://codereview.webrtc.org/2928913002
Cr-Commit-Position: refs/heads/master@{#18529}
Committed: https://chromium.googlesource.com/external/webrtc/+/3fae6280944d71f0f34d926304e8dd9b22873f6b

[tschumi, 2017-06-08 07:51:59]

Patchset #2 (id:20001) has been deleted

[tschumi, 2017-06-08 07:55:05]

Description was changed from

==========
Reland Refactored incoming bitrate estimator.

BUG=webrtc:7746
==========

to

==========
Reland Refactored incoming bitrate estimator.

BUG=webrtc:7746
==========

[tschumi, 2017-06-08 07:55:05]

tschumim@webrtc.org changed reviewers:
+ philipel@webrtc.org, stefan@webrtc.org, terelius@webrtc.org

[stefan-webrtc, 2017-06-08 09:34:36]

https://codereview.webrtc.org/2928913002/diff/40001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc
(right):

https://codereview.webrtc.org/2928913002/diff/40001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc:24: return
packet.payload_size > 0;
I think it's better to check if send_time_ms >= 0. Now you're incorrectly
ignoring empty packets, right?

[tschumi, 2017-06-08 10:31:46]

https://codereview.webrtc.org/2928913002/diff/40001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc
(right):

https://codereview.webrtc.org/2928913002/diff/40001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc:24: return
packet.payload_size > 0;
Are there empty packets sent ? 
But i general i agree. 
Done

[holmer, 2017-06-08 11:16:07]

holmer@google.com changed reviewers:
+ holmer@google.com

[holmer, 2017-06-08 11:16:07]

lgtm

[tschumi, 2017-06-08 12:56:54]

The CQ bit was checked by tschumim@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 12:57:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-08 13:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 13:27:50]

Dry run: Try jobs failed on following builders:
  win_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/14370)

[terelius, 2017-06-09 10:06:38]

lgtm

[tschumi, 2017-06-09 11:10:57]

The CQ bit was checked by tschumim@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 11:11:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-09 11:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 11:18:31]

Dry run: This issue passed the CQ dry run.

[tschumi, 2017-06-12 06:28:23]

The CQ bit was checked by tschumim@webrtc.org

[commit-bot: I haz the power, 2017-06-12 06:28:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 06:32:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 06:32:24]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18012)

[stefan-webrtc, 2017-06-12 06:48:36]

lgtm

[tschumi, 2017-06-12 06:49:55]

The CQ bit was checked by tschumim@webrtc.org

[commit-bot: I haz the power, 2017-06-12 06:50:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 06:57:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497250195260670,
"parent_rev": "90e31904c668e40fec2742cc7a20112304fe0ee1", "commit_rev":
"3fae6280944d71f0f34d926304e8dd9b22873f6b"}

[commit-bot: I haz the power, 2017-06-12 06:57:22]

Description was changed from

==========
Reland Refactored incoming bitrate estimator.

BUG=webrtc:7746
==========

to

==========
Reland Refactored incoming bitrate estimator.

BUG=webrtc:7746

Review-Url: https://codereview.webrtc.org/2928913002
Cr-Commit-Position: refs/heads/master@{#18529}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3fae6280944d71f0f34d92630...
==========

[commit-bot: I haz the power, 2017-06-12 06:57:24]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/3fae6280944d71f0f34d92630...