Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2927983003: Delete ApplicationName and OrganizationName. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, Hzj_jie
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete ApplicationName and OrganizationName. Deleted FilesystemInterface methods: GetOrganizationName SetOrganizationName GetApplicationName SetApplicationName Unused since cl https://codereview.webrtc.org/2533213005. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2927983003 Cr-Commit-Position: refs/heads/master@{#18554} Committed: https://chromium.googlesource.com/external/webrtc/+/29f0d453aaeadac012b6136190e44fdc0bf930d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M webrtc/base/fileutils.h View 2 chunks +0 lines, -37 lines 0 comments Download
M webrtc/base/unittest_main.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
PTAL. I hope these can finally be deleted.
3 years, 6 months ago (2017-06-09 12:48:25 UTC) #2
Taylor Brandstetter
lgtm. I think the linux_internal failure may be caused by something unrelated, by the way.
3 years, 6 months ago (2017-06-09 21:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2927983003/1
3 years, 6 months ago (2017-06-13 08:40:57 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 09:04:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/29f0d453aaeadac012b613619...

Powered by Google App Engine
This is Rietveld 408576698